Tracking resolved comments is a solved problem

Posted Sep 7, 2024 22:26 UTC (Sat) by NYKevin (subscriber, #129325)
In reply to: Tracking resolved comments is a solved problem by nhaehnle
Parent article: Testing AI-enhanced reviews for Linux patches

> First, who gets to mark a comment as "resolved"? If the patch author does it, then who knows whether they have actually addressed the issue properly? There may have been some misunderstanding. If it's the reviewer, well, there's still a lot of load on the reviewer to double-check.

All comments are displayed in the UI (at least for Gerrit, I don't have as much experience with GitHub), and Gerrit also forces you to leave a comment when resolving (but it does have a shortcut button for just commenting "done"). A comment implies an email to the reviewer (if configured to send emails). There's no "sneaking one by."

Ultimately, the reviewer does have to check whether the new diff makes sense as a whole, and review the comments to make sure that requested changes have been implemented correctly. But that's the whole point of code review. If you don't actually want humans reading all of the code and carefully scrutinizing it, then you don't need a review process in the first place. Just pull whatever and back it out when it breaks.