|
|
Subscribe / Log in / New account

Rust block device driver API and null block driver

From:  Andreas Hindborg <nmi-AT-metaspace.dk>
To:  Jens Axboe <axboe-AT-kernel.dk>, Christoph Hellwig <hch-AT-lst.de>, Keith Busch <kbusch-AT-kernel.org>, Damien Le Moal <dlemoal-AT-kernel.org>, Bart Van Assche <bvanassche-AT-acm.org>, Hannes Reinecke <hare-AT-suse.de>, Ming Lei <ming.lei-AT-redhat.com>, "linux-block-AT-vger.kernel.org" <linux-block-AT-vger.kernel.org>
Subject:  [PATCH v2 0/3] Rust block device driver API and null block driver
Date:  Tue, 21 May 2024 16:03:19 +0200
Message-ID:  <20240521140323.2960069-1-nmi@metaspace.dk>
Cc:  Andreas Hindborg <a.hindborg-AT-samsung.com>, Greg KH <gregkh-AT-linuxfoundation.org>, Matthew Wilcox <willy-AT-infradead.org>, Miguel Ojeda <ojeda-AT-kernel.org>, Alex Gaynor <alex.gaynor-AT-gmail.com>, Wedson Almeida Filho <wedsonaf-AT-gmail.com>, Boqun Feng <boqun.feng-AT-gmail.com>, Gary Guo <gary-AT-garyguo.net>, Björn Roy Baron <bjorn3_gh-AT-protonmail.com>, Benno Lossin <benno.lossin-AT-proton.me>, Alice Ryhl <aliceryhl-AT-google.com>, Chaitanya Kulkarni <chaitanyak-AT-nvidia.com>, Luis Chamberlain <mcgrof-AT-kernel.org>, Yexuan Yang <1182282462-AT-bupt.edu.cn>, Sergio González Collado <sergio.collado-AT-gmail.com>, Joel Granados <j.granados-AT-samsung.com>, "Pankaj Raghav (Samsung)" <kernel-AT-pankajraghav.com>, Daniel Gomez <da.gomez-AT-samsung.com>, Niklas Cassel <Niklas.Cassel-AT-wdc.com>, Philipp Stanner <pstanner-AT-redhat.com>, Conor Dooley <conor-AT-kernel.org>, Johannes Thumshirn <Johannes.Thumshirn-AT-wdc.com>, Matias Bjørling <m-AT-bjorling.me>, open list <linux-kernel-AT-vger.kernel.org>, "rust-for-linux-AT-vger.kernel.org" <rust-for-linux-AT-vger.kernel.org>, "lsf-pc-AT-lists.linux-foundation.org" <lsf-pc-AT-lists.linux-foundation.org>, "gost.dev-AT-samsung.com" <gost.dev-AT-samsung.com>
Archive-link:  Article

From: Andreas Hindborg <a.hindborg@samsung.com>

Hi All!

Kernel robot found a few issues with the first iteration of this patch [1]. I
also rebased the patch on the Rust PR for 6.10 [2], because we have some changes
to allocation going in, and this patch needs updates for those changes.

This is a resend to correct those issues.

Changes from v1:

- Fix paths in doc comments so they are correct and `rustdoc` does not complain.
- Fix a typo regarding stabilization of `const_refs_to_static`.
- Properly gate `to_blk_status` behind `CONFIG_BLOCK`.
- Update doc comment, a sector is usually 4096 bytes, not 512.
- Update doc comment, use consistent unit names.
- Rebase on `rust-6.10`.

I did not change the interface to use bytes rather than sectors, even though I
like the idea. I think it is preferable to have some similarity to the C API for
now.

Best regards,
Andreas Hindborg

Link: https://lore.kernel.org/all/20240512183950.1982353-1-nmi@... [1]
Link: https://lore.kernel.org/all/20240512202215.67763-1-ojeda@... [2]

Andreas Hindborg (3):
  rust: block: introduce `kernel::block::mq` module
  rust: block: add rnull, Rust null_blk implementation
  MAINTAINERS: add entry for Rust block device driver API

 MAINTAINERS                        |  14 ++
 drivers/block/Kconfig              |   9 ++
 drivers/block/Makefile             |   3 +
 drivers/block/rnull.rs             |  86 ++++++++++
 rust/bindings/bindings_helper.h    |   2 +
 rust/helpers.c                     |  16 ++
 rust/kernel/block.rs               |   5 +
 rust/kernel/block/mq.rs            |  99 ++++++++++++
 rust/kernel/block/mq/gen_disk.rs   | 206 ++++++++++++++++++++++++
 rust/kernel/block/mq/operations.rs | 245 +++++++++++++++++++++++++++++
 rust/kernel/block/mq/raw_writer.rs |  55 +++++++
 rust/kernel/block/mq/request.rs    | 227 ++++++++++++++++++++++++++
 rust/kernel/block/mq/tag_set.rs    |  93 +++++++++++
 rust/kernel/error.rs               |   6 +
 rust/kernel/lib.rs                 |   2 +
 15 files changed, 1068 insertions(+)
 create mode 100644 drivers/block/rnull.rs
 create mode 100644 rust/kernel/block.rs
 create mode 100644 rust/kernel/block/mq.rs
 create mode 100644 rust/kernel/block/mq/gen_disk.rs
 create mode 100644 rust/kernel/block/mq/operations.rs
 create mode 100644 rust/kernel/block/mq/raw_writer.rs
 create mode 100644 rust/kernel/block/mq/request.rs
 create mode 100644 rust/kernel/block/mq/tag_set.rs


base-commit: 97ab3e8eec0ce79d9e265e6c9e4c480492180409
-- 
2.44.0




Copyright © 2024, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds