| From: |
| Andrew Lunn <andrew-AT-lunn.ch> |
| To: |
| Florian Fainelli <f.fainelli-AT-gmail.com>, Vladimir Oltean <olteanv-AT-gmail.com>, "David S. Miller" <davem-AT-davemloft.net>, Eric Dumazet <edumazet-AT-google.com>, Jakub Kicinski <kuba-AT-kernel.org>, Paolo Abeni <pabeni-AT-redhat.com>, Russell King <linux-AT-armlinux.org.uk>, Gregory Clement <gregory.clement-AT-bootlin.com> |
| Subject: |
| [PATCH RFC 0/7] net: Add generic support for netdev LEDs |
| Date: |
| Sun, 17 Mar 2024 16:45:13 -0500 |
| Message-ID: |
| <20240317-v6-8-0-net-next-mv88e6xxx-leds-v4-v1-0-80a4e6c6293e@lunn.ch> |
| Cc: |
| netdev-AT-vger.kernel.org, Andrew Lunn <andrew-AT-lunn.ch> |
| Archive-link: |
| Article |
For some devices, the MAC controls the LEDs in the RJ45 connector, not
the PHY. This patchset provides generic support for such LEDs, and
adds the first user, mv88e6xxx.
The common code netdev_leds_setup() is passed a DT node containing the
LEDs and a structure of operations to act on the LEDs. The core will
then create an cdev LED for each LED found in the device tree node.
The callbacks are passed the netdev, and the index of the LED. In
order to make use of this within DSA, helpers are added to convert a
netdev to a ds and port.
The mv88e6xxx has been extended to add basic support for the 6352
LEDs. Only software control is added, but the API supports hardware
offload which can be added to the mv88e6xxx driver later.
For testing and demonstration, the Linksys Mamba aka. wrt1900ac has
the needed DT nodes added to describe its LEDs.
RFC:
netdev is closed at the moment.
A previous version of this patchset was specific to DSA. Vladimir
objected to that and suggested the code should be more generic. Hence
now the shared code is moved into net/core and a struct net_device is
used, rather than struct dsa_switch. As a result, there is a bit more
boilerplate needed in DSA drivers.
If this code is accepted, it would be good to convert the qca8k DSA
driver to also use this framework.
Given how hard it is to get kconfig connect for LEDs, i would not be
surprised if this is also broken :-(
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
Andrew Lunn (7):
dsa: move call to driver port_setup after creation of netdev.
net: Add helpers for netdev LEDs
net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness
net: dsa: mv88e6xxx: Tie the low level LED functions to device ops
net: dsa: Add helpers to convert netdev to ds or port index
dsa: mv88e6xxx: Create port/netdev LEDs
arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs
.../boot/dts/marvell/armada-xp-linksys-mamba.dts | 66 +++++++
drivers/net/dsa/mv88e6xxx/Kconfig | 1 +
drivers/net/dsa/mv88e6xxx/chip.c | 125 ++++++++++++-
drivers/net/dsa/mv88e6xxx/chip.h | 19 ++
drivers/net/dsa/mv88e6xxx/port.c | 99 +++++++++++
drivers/net/dsa/mv88e6xxx/port.h | 76 +++++++-
include/net/dsa.h | 17 ++
include/net/netdev_leds.h | 44 +++++
net/Kconfig | 10 ++
net/core/Makefile | 1 +
net/core/netdev-leds.c | 197 +++++++++++++++++++++
net/dsa/devlink.c | 17 +-
net/dsa/dsa.c | 3 +
net/dsa/user.c | 8 +
net/dsa/user.h | 7 -
15 files changed, 665 insertions(+), 25 deletions(-)
---
base-commit: 237bb5f7f7f55ec5f773469a974c61a49c298625
change-id: 20240316-v6-8-0-net-next-mv88e6xxx-leds-v4-ab77d73d52a4
Best regards,
--
Andrew Lunn <andrew@lunn.ch>
