|
|
Subscribe / Log in / New account

LWN's guide to 2024

LWN's guide to 2024

Posted Jan 3, 2024 20:49 UTC (Wed) by rincebrain (subscriber, #69638)
In reply to: LWN's guide to 2024 by dullfire
Parent article: LWN's guide to 2024

Github allows replying to PRs via email, so I don't think it _has_ to violate ToS...


to post comments

LWN's guide to 2024

Posted Jan 3, 2024 21:22 UTC (Wed) by iabervon (subscriber, #722) [Link] (1 responses)

I think there's a federation issue, more than anything else: can kernel.org do anything that appropriately conveys that Al Viro reviewed the PR in a message kernel.org received from him? Or can kernel.org deliver Al Viro a useful email such that, if he replies in the usual way, the review arrives in the PR appropriately? (Al Viro being an example of someone whose normal email address is not at kernel.org.)

The forge and the email list probably have to be able to trust each other to have done the appropriate authentication of the attribution of review comments before transforming them in ways that preserve the meaning, which probably requires some sort of special agreement to be not too awkward.

I guess it might be okay to have the GitHub PR get a lot of review comments by kernel.org that say "according to (link to lore), (real person) says: (extracted comment about that part)", which kernel.org could add on its own behalf.

LWN's guide to 2024

Posted Jan 7, 2024 18:10 UTC (Sun) by mathstuf (subscriber, #69389) [Link]

I believe that every "issuable" has its own email address (using `+unique-id`-style addresses) and the sender is associated with the user account that sent the email (probably based on `From`, so mailing list header-rewriting might need to change). I don't know what happens if you send something to such an address without an associated GitHub account with the sending email address.


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds