|
|
Subscribe / Log in / New account

Reducing kernel-maintainer burnout

Reducing kernel-maintainer burnout

Posted Nov 26, 2023 17:13 UTC (Sun) by khim (subscriber, #9252)
In reply to: Reducing kernel-maintainer burnout by adobriyan
Parent article: Reducing kernel-maintainer burnout

> The ability to point specific line and write comment near it (in a monospace font!) is what's needed.

Gerrit uses Markdown so you write in a monospace font like this:

Here is how I would do that:
```
if (foo) {
  ...
} else {
  ...
}
```

Here's just some random example. Where, ironically, enough, you may see discussion about commit message with embedded code snippets in a monospaced font.

I haven't looked for that, just clicked on some change with large number of unadressed comments.

Not sure how well Gerrit would scale to the Linux kernel scale, but if there are limited number of reviewers it works very nicely: each “subdiscussion” is attached to some piece of code and there's status to know if it's addressed or not, you may easily see how many complains are not addressed.

The biggest issue is that often when you address the comment and rewrite the code gerrit couldn't find the point to attach it in the new version of patch and then it just shows it at the top of the file. Then you open the previous version of patch and look on comments on the left and code on the right.

Not ideal, but not sure that part is handled by e-mail any better.


to post comments

Reducing kernel-maintainer burnout

Posted Nov 26, 2023 17:40 UTC (Sun) by excors (subscriber, #95769) [Link]

I think your example is a non-public link, but the same review is public here instead.


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds