Re: [PATCH] Use NULL instead of integer 0 in security/selinux/

[Posted July 14, 2004 by corbet]

From:		Linus Torvalds <torvalds-AT-osdl.org>
To:		"Eric W. Biederman" <ebiederm-AT-xmission.com>
Subject:		Re: [PATCH] Use NULL instead of integer 0 in security/selinux/
Date:		Fri, 9 Jul 2004 23:23:52 -0700 (PDT)
Cc:		Herbert Xu <herbert-AT-gondor.apana.org.au>, Chris Wright <chrisw-AT-osdl.org>, akpm-AT-osdl.org, linux-kernel-AT-vger.kernel.org, sds-AT-epoch.ncsc.mil, jmorris-AT-redhat.com, mika-AT-osdl.org

On Fri, 9 Jul 2004, Linus Torvalds wrote:
> 
> Problems arise when there is room for confusion, and that's when the 
> compiler should (and does) warn. If something is unambiguous, it's not 
> bad.

Btw, has anybody who is complaining about the 0/NULL fixing actually 
_looked_ at the code?

Every single time a 0 was replaced by a NULL it was an obvious
_improvement_ to the code. Not just "once". EVERY SINGLE TIME. It might be
irritating to see the patches, and there might be too many of them since
nothing has ever automatically noticed the bugs until now, but the fact
is, there is not even any gray areas here - if you look at any of the
patches being applied, they are ALL clearly making things more readable in
their local context.

I really don't see the point of complaining about the fixes. There's just
_no_ way to say that "0" is more readable than "NULL" in any of the cases.  
I dare you - show _one_ case where a 0/NULL patch was wrong or even
remotely debatable. I dare you.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/