Software Freedom Conservancy: Give Up GitHub: The Time Has Come!

Posted Jul 3, 2022 13:45 UTC (Sun) by vimpostor (guest, #159442)
In reply to: Software Freedom Conservancy: Give Up GitHub: The Time Has Come! by ddevault
Parent article: Software Freedom Conservancy: Give Up GitHub: The Time Has Come!

> SourceHut also tracks the review status of patches: https://lists.sr.ht/~sircmpwn/hare-dev/patches/

That looks really nice, but I wonder how does Sourcehut actually know whether a patch is applied?
Surely it can only reliably detect this, if you apply using the web interface.

I however like to apply from the command line and sometimes edit the patch before applying for some minor code style changes. Obviously this changes the patch, so how would Sourcehut know in that case that the patch was applied?

Software Freedom Conservancy: Give Up GitHub: The Time Has Come!

Posted Jul 3, 2022 13:55 UTC (Sun) by ddevault (subscriber, #99589) [Link] (2 responses)

Right now it's done semi-manually. You can change the patchset status through special email headers (I have my mail client configured to add these when I reply to say "thanks" for the patch), or through the API.

But we intend to make it automatic. The essential heuristic is the commit date, which matches the Date header and survives amending and rebasing.

Software Freedom Conservancy: Give Up GitHub: The Time Has Come!

Posted Jul 3, 2022 15:17 UTC (Sun) by mathstuf (subscriber, #69389) [Link] (1 responses)

> The essential heuristic is the commit date, which matches the Date header and survives amending and rebasing.

Wouldn't the author date be the one to trust?

Software Freedom Conservancy: Give Up GitHub: The Time Has Come!

Posted Jul 3, 2022 15:35 UTC (Sun) by ddevault (subscriber, #99589) [Link]

Right, my mistake.