| From: |
| Caleb Connolly <caleb.connolly-AT-linaro.org> |
| To: |
| caleb.connolly-AT-linaro.org, Jonathan Cameron <jic23-AT-kernel.org>, Lars-Peter Clausen <lars-AT-metafoo.de>, Rob Herring <robh+dt-AT-kernel.org>, Andy Gross <agross-AT-kernel.org>, Bjorn Andersson <bjorn.andersson-AT-linaro.org>, Lee Jones <lee.jones-AT-linaro.org>, linux-iio-AT-vger.kernel.org, devicetree-AT-vger.kernel.org, linux-arm-msm-AT-vger.kernel.org |
| Subject: |
| [PATCH v4 0/8] iio: adc: introduce Qualcomm SPMI Round Robin ADC |
| Date: |
| Fri, 11 Feb 2022 21:19:51 +0000 |
| Message-ID: |
| <20220211211959.502514-1-caleb.connolly@linaro.org> |
| Cc: |
| sumit.semwal-AT-linaro.org, amit.pundir-AT-linaro.org, john.stultz-AT-linaro.org |
| Archive-link: |
| Article |
The RRADC is responsible for reading data about the current and
voltage from the USB or DC in jacks, it can also read the battery
ID (resistence) and some temperatures. It is found on the PMI8998 and
PM660 Qualcomm PMICs.
The RRADC has to calibrate some ADC values based on which chip fab
the PMIC was produced in, to facilitate this the patches
("mfd: qcom-spmi-pmic: expose the PMIC revid information to clients")
and ("mfd: qcom-spmi-pmic: read fab id on supported PMICs")
expose the PMIC revision information and fab_id as a struct and register
them as driver data in the Qualcomm SPMI PMIC driver so that it can be
read by the RRADC.
Changes since v3:
* Split PMIC patch in two, rework to support function drivers on a
sibling USID
* Completely rework RRADC driver to make use of the modern IIO
framework. This required re-arranging a lot of the equations and
results in some lost precision, where relevant I've left comments to
explain this. I don't think any of it is significant enough to
justify doing post-processing in driver.
Thanks a lot Jonathan and John Stultz for helping me out with
this :)
Changes since v2:
* Add missing include (thanks kernel test robot :D)
* Rework some confusing function return values, specifically
rradc_read_status_in_cont_mode and rradc_prepare_batt_id_conversion
both of which didn't correctly handle "ret". This also bought up an
issue as the previous implementation didn't actually wait for the
channel to be ready. It doesn't seem like that's strictly necessary
(same data is reported if I wait for the status to be good or not)
but I've included it anyway for good measure.
Changes since v1:
* Rework the RRADC driver based on Jonathan's feedback
* Pick up Rob's reviewed by for the dt-binding patch.
Caleb Connolly (8):
mfd: qcom-spmi-pmic: expose the PMIC revid information to clients
mfd: qcom-spmi-pmic: read fab id on supported PMICs
dt-bindings: iio: adc: document qcom-spmi-rradc
iio: adc: qcom-spmi-rradc: introduce round robin adc
arm64: dts: qcom: pmi8998: add rradc node
arm64: dts: qcom: sdm845-oneplus: enable rradc
arm64: dts: qcom: sdm845-db845c: enable rradc
arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc
.../bindings/iio/adc/qcom,spmi-rradc.yaml | 54 +
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 +
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 +
.../boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 +
.../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 4 +
drivers/iio/adc/Kconfig | 13 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/qcom-spmi-rradc.c | 1014 +++++++++++++++++
drivers/mfd/qcom-spmi-pmic.c | 159 ++-
include/soc/qcom/qcom-spmi-pmic.h | 61 +
10 files changed, 1265 insertions(+), 57 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml
create mode 100644 drivers/iio/adc/qcom-spmi-rradc.c
create mode 100644 include/soc/qcom/qcom-spmi-pmic.h
--
2.35.1
