|
|
Subscribe / Log in / New account

PostgreSQL's commitfest clog

PostgreSQL's commitfest clog

Posted Aug 13, 2021 14:28 UTC (Fri) by intelfx (subscriber, #130118)
In reply to: PostgreSQL's commitfest clog by iabervon
Parent article: PostgreSQL's commitfest clog

> If it was already there and nobody reviewed it, it's unlikely that anyone will review it in the future unless something gets done to change the situation.

Auto-dropping patches if they don't get attention sounds contrary to the idea of commitfests. What do I do as an author of the patch if it just gets ignored through no fault of my own? What *can* I do to "change the situation"?


to post comments

PostgreSQL's commitfest clog

Posted Aug 14, 2021 1:08 UTC (Sat) by iabervon (subscriber, #722) [Link]

Talk about its benefits on the mailing list? Add explanation as to how it's organized? Ask if there's a better way to design it? Ideally, the commitfest manager would have some suggestions particular to the patch about what might be putting reviewers off.

Often a patch will get the code exactly right, but the commit message doesn't explain enough about why it's right and give reviewers enough information to check that the author understands the implications entirely. It's almost always possible to add more to the presentation of the patch such that the code ends up the same but the review is easier to do or, especially, easier to get started on. A patch that touches several files will generally have the diffs ordered alphabetically and that's likely not the order in which a logical argument for making the change would go. Beyond the point where the patch is correct and applying it would be the right thing to do, there's a variety of ways that a patch author can make it more obvious that that is the case, and it may be necessary to make the patch more approachable in non-technical ways in order to motivate reviewers.

PostgreSQL's commitfest clog

Posted Aug 15, 2021 18:03 UTC (Sun) by NYKevin (subscriber, #129325) [Link]

I wonder what would happen if they adopted the opposite policy: If nobody reviews it, that means nobody has any objections to it, so let's just merge it with no review.

This would, at the very least, provide a stronger motivation for more senior developers to review old patches that are close to the limit (i.e. "you had better review it now, or else it might just get merged by default"). However, I don't imagine it would be appropriate to make such a policy retroactive, and there would probably need to be some kind of limiting principle to prevent abuse (e.g. only if you've sent at least X accepted patches in the past, only if you have fewer than X other patches outstanding, etc.).


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds