PostgreSQL's commitfest clog
PostgreSQL's commitfest clog
Posted Aug 12, 2021 15:44 UTC (Thu) by kleptog (subscriber, #1183)Parent article: PostgreSQL's commitfest clog
For people who work on Postgres for a lot of time the cost is lower because they already know the code, and they already know many of the other core developers so know which bit they have to pay attention to.
At $DAYJOB code needs to be reviewed but there's a different dynamic in play. If you don't immediately understand something you simply talk to the person who wrote it. By asking questions you get an idea of (a) why was this solution chosen (b) what are the risks (c) what's the skill level so I know which kind of bugs I need to watch for. Also get a feeling of the urgency. A patch that has been in the queue for a year might be useless, or the writer has had it running in production that whole time and is confident it works. You can do this via email but, well, for complex patches that doesn't cut it.
Not sure if there's any easy solution, but I can imagine that for complex/controversial patches that a quick chat between the writer and a reviewer can help make a lot more progress than a commitfest manager sending emails. And I have no doubt that in-person conferences in the past helped immensely here.
Posted Aug 13, 2021 13:06 UTC (Fri)
by taladar (subscriber, #68407)
[Link] (1 responses)
Reviews always require context and someone who never looked at the code base simply does not have that context.
Posted Aug 13, 2021 13:14 UTC (Fri)
by andresfreund (subscriber, #69562)
[Link]
PostgreSQL's commitfest clog
PostgreSQL's commitfest clog