|
|
Subscribe / Log in / New account

PostgreSQL's commitfest clog

PostgreSQL's commitfest clog

Posted Aug 12, 2021 15:44 UTC (Thu) by kleptog (subscriber, #1183)
Parent article: PostgreSQL's commitfest clog

"Preferably of similar complexity" is difficult in another way. At $DAYJOB I found an issue with Postgres and spent more than a week digging through code I'd never seen before, debugging it and eventually coming up with a solution, after some emails to the mailing list for clues. What is then "similar complexity"? Another patch that would take another week to dig into the code to understand what it does before you feel qualified to have an opinion?

For people who work on Postgres for a lot of time the cost is lower because they already know the code, and they already know many of the other core developers so know which bit they have to pay attention to.

At $DAYJOB code needs to be reviewed but there's a different dynamic in play. If you don't immediately understand something you simply talk to the person who wrote it. By asking questions you get an idea of (a) why was this solution chosen (b) what are the risks (c) what's the skill level so I know which kind of bugs I need to watch for. Also get a feeling of the urgency. A patch that has been in the queue for a year might be useless, or the writer has had it running in production that whole time and is confident it works. You can do this via email but, well, for complex patches that doesn't cut it.

Not sure if there's any easy solution, but I can imagine that for complex/controversial patches that a quick chat between the writer and a reviewer can help make a lot more progress than a commitfest manager sending emails. And I have no doubt that in-person conferences in the past helped immensely here.


to post comments

PostgreSQL's commitfest clog

Posted Aug 13, 2021 13:06 UTC (Fri) by taladar (subscriber, #68407) [Link] (1 responses)

Agreed. The idea that someone who contributes a single patch for a problem they themselves encountered in production and who has otherwise never looked at the code base should review a patch of similar complexity is ridiculous.

Reviews always require context and someone who never looked at the code base simply does not have that context.

PostgreSQL's commitfest clog

Posted Aug 13, 2021 13:14 UTC (Fri) by andresfreund (subscriber, #69562) [Link]

I don't think small bug fixes or very simple one-off improvements are a significant part of the problem. They're easily enough committed and reviewed. What tends to clog up things are patches there's no agreements for and large patchsets that aren't quite there, but good enough to not just want to throw them out.


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds