|
|
Subscribe / Log in / New account

Home Assistant, the Python IoT Hub

Home Assistant, the Python IoT Hub

Posted Jun 12, 2020 17:51 UTC (Fri) by Cyberax (✭ supporter ✭, #52523)
In reply to: Home Assistant, the Python IoT Hub by Fishwaldo
Parent article: Home Assistant, the Python IoT hub

Sorry, but your library needs refactoring. This is the truth.

A well-behaved library just shouldn't do behind-the-scenes DNS lookups and unsecured HTTP downloads to update files in the filesystem. Neither should it manage its own volatile state using flat files.

I'll send patches to at least correct the config storage problems so customizable backends (like an SQLite database) could be used. I might not have enough energy to fix all other issues (like raw C++ pointers everywhere for no reason).

And if you feel that commercial products unfairly use your library then change its license to GPLv3 and offer alternative commercial licenses. It will help a lot.


to post comments

Home Assistant, the Python IoT Hub

Posted Jun 14, 2020 12:14 UTC (Sun) by beagnach (guest, #32987) [Link]

Your overall intent may be good but the critical language and somewhat condescending attitude will just undermine any good you try to do. I'm not sure I'd accept patches from someone who introduced themselves in that manner.

In the end we're all human. We've all had that project where we learned some new language and made all the beginner mistakes. Some of us were lucky enough to do it in private, or with good mentors. Others had to do it in public and have their beginner mistakes visible to the world.

There's not need to be so harsh. There's probably code still living somewhere that you're probably not too proud of.

also
> I might not have enough energy to fix all other issues...

If you don't have the energy then why would you expect the maintainer to? Again, we're all only human, with limited time and energy.

So if you want to make a positive contribution, don't just snipe from the sidelines and make some drive-by pull request.
Loose the superior attitude and approach this as one fallible human being making a contribution to a project run by another fallible human being.


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds