Bad Binder: Android In-The-Wild Exploit (Project Zero)

Posted Nov 26, 2019 13:52 UTC (Tue) by cyphar (subscriber, #110703)
In reply to: Bad Binder: Android In-The-Wild Exploit (Project Zero) by error27
Parent article: Bad Binder: Android In-The-Wild Exploit (Project Zero)

I agree, and there really should be a push for folks to include Fixes tags (I'm surprised there isn't a rule about Cc-ing stable without a Fixes tag being a no-no). If you went through all the effort to fix a bug and test it, a quick blame to find where the bug was introduced is usually (in my experience) not too much extra effort. To be fair, this won't always be entirely accurate (and the most accurate test is actually try to exploit it) but it's almost certainly good enough for the vast majority of such patches.

A lot of the discussion about this bug is around classifying certain types of patches as security fixes, but GregKH has consistently said that stable considers all bugs to be security bugs. In fact the patch *was* backported to stable (just not to all the trees that needed it).

Bad Binder: Android In-The-Wild Exploit (Project Zero)

Posted Dec 5, 2019 14:17 UTC (Thu) by hmh (subscriber, #3838) [Link]

I understand there has been some cases of "bad feelings" over being the target of a "fixes" tag when the target commit only exposed an underlying issue, etc. Especially when there is already some friction between the people (or companies, or teams, or tribes, or...) involved.

I'd propose using "Canary:" [insert bikeshedding here] instead of "Fixes" in that case, though :-) As in "if the commit listed in Canary is present, or a backport thereof, you very very likely also want this commit for the whole thing to work better, no specific reason implied".