Next steps for kernel workflow improvement

Posted Nov 8, 2019 19:16 UTC (Fri) by error27 (subscriber, #8346)
Parent article: Next steps for kernel workflow improvement

I send patches by email but I have to add a header "X-Mailer: git-send-email haha only kidding" to my email headers otherwise there is one subsystem patchwork which rejects it. Also if you don't have the diffstat (keep in mind that all my patches are exactly 1 line long) or say [patch] instead of [PATCH] then it causes problems.

So sending patches by email doesn't work right now. But the git commands to send a patch is pretty complicated.

$ git format-patch HEAD~
$ git send-email --cc-cmd='./scripts/get_maintainer.pl --norolestats 0001-my.patch' --cc my@email.com 0001-my.patch

Probably someone should make an interactive helper script called ./scripts/send_patch <hash> which does it automatically. It could run checkpatch etc.

Next steps for kernel workflow improvement

Posted Nov 12, 2019 10:10 UTC (Tue) by geert (subscriber, #98403) [Link] (1 responses)

Please don't feed the output of "scripts/get_maintainer.pl" to "git send-email" mindlessly, but apply some common sense to reduce the list if it's long ("get_maintainer.pl considered harmful").
BTW, doesn't "git send-email" add "my@email.com" automatically, based on the "From:" in the patch? Or is this need a side effect of using "--cc-cmd"?

Next steps for kernel workflow improvement

Posted Nov 13, 2019 18:09 UTC (Wed) by error27 (subscriber, #8346) [Link]

Just using it mindlessly is the safest way. The only time I ever see complaints is when someone tries to get clever and leave something off. I sometimes remove LKML but you have to be careful with that because some people use it for patchwork.

I manually remove Greg, Kees and Colin if it's not something I think they care about. But those people are used to getting tons of mail so they don't mind either way.