| From: |
| Yash Shah <yash.shah-AT-sifive.com> |
| To: |
| palmer-AT-sifive.com, linux-pwm-AT-vger.kernel.org, linux-riscv-AT-lists.infradead.org |
| Subject: |
| [PATCH v6 0/2] PWM support for HiFive Unleashed |
| Date: |
| Wed, 13 Feb 2019 14:56:16 +0530 |
| Message-ID: |
| <1550049978-20705-1-git-send-email-yash.shah@sifive.com> |
| Cc: |
| thierry.reding-AT-gmail.com, robh+dt-AT-kernel.org, mark.rutland-AT-arm.com, devicetree-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, sachin.ghadi-AT-sifive.com, paul.walmsley-AT-sifive.com, Yash Shah <yash.shah-AT-sifive.com> |
| Archive-link: |
| Article |
This patch series adds a PWM driver and DT documentation
for HiFive Unleashed board. The patches are mostly based on
Wesley's patch.
v6
- Remove the global property 'sifive,period-ns'
- Implement free and request callbacks to maintain user counts.
- Add user_count member to struct pwm_sifive_ddata
- Allow period change only if user_count is one
- Add pwm_sifive_enable function to enable/disable PWM
- Change calculation logic of frac (in pwm_sifive_apply)
- Remove state correction
- Remove pwm_sifive_xlate function
- Clock to be enabled only when PWM is enabled
- Other minor fixes
v5
- Correct the order of compatible string properties
- PWM state correction to be done always
- Other minor fixes based upon feedback on v4
v4
- Rename the property sifive,approx-period-ns to sifive,period-ns
- Rename macros with appropriate names
- Remove unused macros
- Rename struct sifive_pwm_device to struct pwm_sifive_ddata
- Rename function prefix as per driver name
- Set deglitch bit before changing output waveform.
- Other minor fixes based upon feedback on v3
v3
- Add a link to the reference manaul
- Use appropriate apis for division operation
- Add check for polarity
- Enable clk before calling clk_get_rate
- Other minor fixes based upon feedback on v2
V2 changed from V1:
- Remove inclusion of dt-bindings/pwm/pwm.h
- Remove artificial alignments
- Replace ioread32/iowrite32 with readl/writel
- Remove camelcase
- Change dev_info to dev_dbg for unnecessary log
- Correct typo in driver name
- Remove use of of_match_ptr macro
- Update the DT compatible strings and Add reference to a common
versioning document
Yash Shah (2):
pwm: sifive: Add DT documentation for SiFive PWM Controller
pwm: sifive: Add a driver for SiFive SoC PWM
.../devicetree/bindings/pwm/pwm-sifive.txt | 30 ++
drivers/pwm/Kconfig | 11 +
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-sifive.c | 311 +++++++++++++++++++++
4 files changed, 353 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sifive.txt
create mode 100644 drivers/pwm/pwm-sifive.c
--
1.9.1