| From: |
| David Howells <dhowells-AT-redhat.com> |
| To: |
| linux-api-AT-vger.kernel.org, linux-kbuild-AT-vger.kernel.org |
| Subject: |
| [RFC] UAPI: Check headers by compiling all together as C++ |
| Date: |
| Wed, 05 Sep 2018 16:54:27 +0100 |
| Message-ID: |
| <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> |
| Cc: |
| Michal Marek <michal.lkml-AT-markovi.net>, dri-devel-AT-lists.freedesktop.org, virtualization-AT-lists.linux-foundation.org, keyrings-AT-vger.kernel.org, David Airlie <airlied-AT-linux.ie>, linux-nilfs-AT-vger.kernel.org, linux-nvdimm-AT-lists.01.org, "Michael S. Tsirkin" <mst-AT-redhat.com>, codalist-AT-coda.cs.cmu.edu, coda-AT-cs.cmu.edu, coreteam-AT-netfilter.org, Rob Clark <robdclark-AT-gmail.com>, linux-arm-msm-AT-vger.kernel.org, Kent Overstreet <kent.overstreet-AT-gmail.com>, Dan Williams <dan.j.williams-AT-intel.com>, Takashi Iwai <tiwai-AT-suse.com>, linux-bcache-AT-vger.kernel.org, Coly Li <colyli-AT-suse.de>, Jaroslav Kysela <perex-AT-perex.cz>, Jan Harkes <jaharkes-AT-cs.cmu.edu>, Masahiro Yamada <yamada.masahiro-AT-socionext.com>, Ryusuke Konishi <konishi.ryusuke-AT-lab.ntt.co.jp>, Jason Wang <jasowang-AT-redhat.com>, Mat Martineau <mathew.j.martineau-AT-linux.intel.com>, netfilter-devel-AT-vger.kernel.org, linux-fsdevel-AT-vger.kernel.org, moderated for non-subscribers <alsa-devel-AT-alsa-project.org>, freedreno-AT-lists.freedesktop.org, linux-kernel-AT-vger.kernel.org, dhowells-AT-redhat.com |
| Archive-link: |
| Article |
Here's a set of patches that inserts a step into the build process to make
sure that the UAPI headers can all be built together with C++ (if the
compiler being used supports C++). All but the final patch perform fixups,
including:
(1) Fix member names that conflict with C++ reserved words by providing
alternates that can be used anywhere. An anonymous union is used so
that that the conflicting name is still available outside of C++.
(2) Fix the use of flexible arrays in structs that get embedded (which is
illegal in C++).
(3) Remove the use of internal kernel structs in UAPI structures.
(4) Fix symbol collisions.
(5) Replace usage of u32 and co. with __u32 and co.
(6) Fix use of sparsely initialised arrays (which g++ doesn't implement).
(7) Remove some use of PAGE_SIZE since this isn't valid outside of the
kernel.
And lastly:
(8) Compile all of the UAPI headers (with a few exceptions) together as
C++ to catch new errors occurring as part of the regular build
process.
The patches can also be found here:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linu...
Thanks,
David
---
David Howells (11):
UAPI: drm: Fix use of C++ keywords as structural members
UAPI: keys: Fix use of C++ keywords as structural members
UAPI: virtio_net: Fix use of C++ keywords as structural members
UAPI: bcache: Fix use of embedded flexible array
UAPI: coda: Don't use internal kernel structs in UAPI
UAPI: netfilter: Fix symbol collision issues
UAPI: nilfs2: Fix use of undefined byteswapping functions
UAPI: sound: Fix use of u32 and co. in UAPI headers
UAPI: ndctl: Fix g++-unsupported initialisation in headers
UAPI: ndctl: Remove use of PAGE_SIZE
UAPI: Check headers build for C++
Makefile | 1
include/linux/ndctl.h | 22 ++++
include/uapi/drm/i810_drm.h | 7 +
include/uapi/drm/msm_drm.h | 7 +
include/uapi/linux/bcache.h | 2
include/uapi/linux/coda_psdev.h | 4 +
include/uapi/linux/keyctl.h | 7 +
include/uapi/linux/ndctl.h | 20 ++-
include/uapi/linux/netfilter/nfnetlink_cthelper.h | 2
include/uapi/linux/netfilter_ipv4/ipt_ECN.h | 9 --
include/uapi/linux/nilfs2_ondisk.h | 21 ++--
include/uapi/linux/virtio_net.h | 7 +
include/uapi/sound/skl-tplg-interface.h | 106 +++++++++---------
scripts/headers-c++.sh | 124 +++++++++++++++++++++
14 files changed, 255 insertions(+), 84 deletions(-)
create mode 100644 include/linux/ndctl.h
create mode 100755 scripts/headers-c++.sh
