| From: |
| Michael Ellerman <mpe-AT-ellerman.id.au> |
| To: |
| Michal Hocko <mhocko-AT-kernel.org>, Kees Cook <keescook-AT-chromium.org> |
| Subject: |
| Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE |
| Date: |
| Wed, 06 Dec 2017 15:50:09 +1100 |
| Message-ID: |
| <87zi6we9z2.fsf@concordia.ellerman.id.au> |
| Cc: |
| Linux API <linux-api-AT-vger.kernel.org>, Khalid Aziz <khalid.aziz-AT-oracle.com>, Andrew Morton <akpm-AT-linux-foundation.org>, Russell King - ARM Linux <linux-AT-armlinux.org.uk>, Andrea Arcangeli <aarcange-AT-redhat.com>, Linux-MM <linux-mm-AT-kvack.org>, LKML <linux-kernel-AT-vger.kernel.org>, linux-arch <linux-arch-AT-vger.kernel.org>, Florian Weimer <fweimer-AT-redhat.com>, John Hubbard <jhubbard-AT-nvidia.com>, Abdul Haleem <abdhalee-AT-linux.vnet.ibm.com>, Joel Stanley <joel-AT-jms.id.au> |
Michal Hocko <mhocko@kernel.org> writes:
> On Wed 29-11-17 14:25:36, Kees Cook wrote:
>> On Wed, Nov 29, 2017 at 6:42 AM, Michal Hocko <mhocko@kernel.org> wrote:
>> > The first patch introduced MAP_FIXED_SAFE which enforces the given
>> > address but unlike MAP_FIXED it fails with ENOMEM if the given range
>> > conflicts with an existing one. The flag is introduced as a completely
>>
>> I still think this name should be better. "SAFE" doesn't say what it's
>> safe from...
Yes exactly.
> It is safe in a sense it doesn't perform any address space dangerous
> operations. mmap is _inherently_ about the address space so the context
> should be kind of clear.
So now you have to define what "dangerous" means.
>> MAP_FIXED_UNIQUE
>> MAP_FIXED_ONCE
>> MAP_FIXED_FRESH
>
> Well, I can open a poll for the best name, but none of those you are
> proposing sound much better to me. Yeah, naming sucks...
I think Kees and I both previously suggested MAP_NO_CLOBBER for the
modifier.
So the obvious option for this would be MAP_FIXED_NO_CLOBBER.
Which is a bit longer sure, but says more or less exactly what it does.
cheers
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
