| From: |
| Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ-AT-public.gmane.org> |
| To: |
| Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA-AT-public.gmane.org>, Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r-AT-public.gmane.org>, Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ-AT-public.gmane.org>, Ping-Ke Shih <pkshih-Rasf1IRRPZFBDgjK7y7TUQ-AT-public.gmane.org>, Yan-Hsuan Chuang <yhchuang-Rasf1IRRPZFBDgjK7y7TUQ-AT-public.gmane.org>, Johannes Berg <johannes.berg-ral2JQCrhuEAvxtiuMwx3w-AT-public.gmane.org>, Souptick Joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w-AT-public.gmane.org>, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b-AT-public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org |
| Subject: |
| Two rtlwifi drivers? |
| Date: |
| Thu, 24 Aug 2017 15:14:17 +0300 |
| Message-ID: |
| <87h8wxw4bq.fsf@kamboji.qca.qualcomm.com> |
Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> writes:
> Smatch is distrustful of the "capab" value and marks it as user
> controlled. I think it actually comes from the firmware? Anyway, I
> looked at other drivers and they added a bounds check and it seems like
> a harmless thing to have so I have added it here as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index f7f207cbaee3..a30b928d5ee1 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
I'm getting slightly annoyed that we now apparently have two duplicate
rtlwifi drivers (with the same name!) and I'm being spammed by staging
patches. Was this really a smart thing to do? And what will be the
future of these two drivers?
(Of course this is not directed to Dan, he is just fixing bugs found by
smatch, but more like a general question.)
--
Kalle Valo
