|
|
Subscribe / Log in / New account

The case of the prematurely freed SKB

The case of the prematurely freed SKB

Posted Mar 2, 2017 8:25 UTC (Thu) by wsa (guest, #52415)
In reply to: The case of the prematurely freed SKB by marcH
Parent article: The case of the prematurely freed SKB

Yes, coccinelle is awesome for finding other mushrooms. But picking them (=fixing bugs) requires a lot more attention.

I used to do that. When I received a bugfix in my subsystem which looked like a generic issue to me, I wrote a coccinelle script to see how widespread it was. However, fixing it automatically was seldomly possible. Usually, the coccinelle generated patches needed manual changes and a really careful review in order to avoid regressions. The code in question was often not touched for a while, so getting it upstream without being able to test it was slow (rightfully, I'd say).

That all easily exceeded the free-time capacity I had for hacking such stuff. I tried to get funding for it but failed ("no predictable deliverables"). So, I stopped writing cocci scripts because knowing where mushrooms are and then not being able to pick them gets frustrating.


to post comments

The case of the prematurely freed SKB

Posted Mar 3, 2017 15:48 UTC (Fri) by grmd (guest, #4391) [Link] (3 responses)

> knowing where mushrooms are and then not being able to pick them gets frustrating

Would it have been possible to identify likely errors and raise them for others to consider?

The case of the prematurely freed SKB

Posted Mar 3, 2017 17:23 UTC (Fri) by wsa (guest, #52415) [Link] (2 responses)

Well, identifying the real problems from false positives is one big chunk of the work already. coccinelle is awesome for finding points of interest, but they all need proper review and second thought. And posting lists with false positives is not a good idea IMO.

The case of the prematurely freed SKB

Posted Mar 3, 2017 18:15 UTC (Fri) by marcH (subscriber, #57642) [Link] (1 responses)

> And posting lists with false positives is not a good idea IMO.

Lists not. Maintainers why not?

The case of the prematurely freed SKB

Posted Mar 3, 2017 19:34 UTC (Fri) by wsa (guest, #52415) [Link]

Frankly, didn't think of that. Has pros and cons, but yeah, might be an option for some cases.


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds