|
|
Subscribe / Log in / New account

Re: CONFIG_VMAP_STACK, on-stack struct, and wake_up_bit

From:  Linus Torvalds <torvalds-AT-linux-foundation.org>
To:  Andy Lutomirski <luto-AT-amacapital.net>
Subject:  Re: CONFIG_VMAP_STACK, on-stack struct, and wake_up_bit
Date:  Wed, 26 Oct 2016 10:58:01 -0700
Message-ID:  <CA+55aFyRv0YttbLUYwDem=-L5ZAET026umh6LOUQ6hWaRur_VA@mail.gmail.com>
Cc:  Andreas Gruenbacher <agruenba-AT-redhat.com>, Peter Zijlstra <peterz-AT-infradead.org>, Andy Lutomirski <luto-AT-kernel.org>, LKML <linux-kernel-AT-vger.kernel.org>, Bob Peterson <rpeterso-AT-redhat.com>, Steven Whitehouse <swhiteho-AT-redhat.com>, Mel Gorman <mgorman-AT-techsingularity.net>, linux-mm <linux-mm-AT-kvack.org>

On Wed, Oct 26, 2016 at 10:15 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Oh, and the patch is obviously entirely untested. I wouldn't want to
> ruin my reputation by *testing* the patches I send out. What would be
> the fun in that?

So I tested it. It compiles, and it actually also solves the
performance problem I was complaining about a couple of weeks ago with
"unlock_page()" having an insane 3% CPU overhead when doing lots of
small script ("make -j16 test" in the git tree for those that weren't
involved in the original thread three weeks ago).

So quite frankly, I'll just commit it. It should fix the new problem
with gfs2 and CONFIG_VMAP_STACK, and I see no excuse for the crazy
zone stuff considering how harmful it is to everybody else.

I expect that when the NUMA people complain about page locking (if
they ever even notice), PeterZ will stand up like the hero he is, and
say "look here, I can solve this for you".

                    Linus



to post comments


Copyright © 2016, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds