Re: [PATCH 0/9] mm: Hardened usercopy
[Posted August 2, 2016 by jake]
| From: |
| Andy Lutomirski <luto-AT-amacapital.net> |
| To: |
| Kees Cook <keescook-AT-chromium.org> |
| Subject: |
| Re: [PATCH 0/9] mm: Hardened usercopy |
| Date: |
| Sat, 9 Jul 2016 14:27:25 -0700 |
| Message-ID: |
| <CALCETrU5Emr7jZNH5bh7Z+C8fLOcAah9SzeJbDjqW7N-xWGxHA@mail.gmail.com> |
| Cc: |
| Christoph Lameter <cl-AT-linux.com>, Andrew Morton <akpm-AT-linux-foundation.org>, Brad Spengler <spender-AT-grsecurity.net>, Pekka Enberg <penberg-AT-kernel.org>, Ard Biesheuvel <ard.biesheuvel-AT-linaro.org>, Casey Schaufler <casey-AT-schaufler-ca.com>, Will Deacon <will.deacon-AT-arm.com>, Rik van Riel <riel-AT-redhat.com>, Benjamin Herrenschmidt <benh-AT-kernel.crashing.org>, Dmitry Vyukov <dvyukov-AT-google.com>, "linux-ia64-AT-vger.kernel.org" <linux-ia64-AT-vger.kernel.org>, "linux-arm-kernel-AT-lists.infradead.org" <linux-arm-kernel-AT-lists.infradead.org>, X86 ML <x86-AT-kernel.org>, Catalin Marinas <catalin.marinas-AT-arm.com>, linux-arch <linux-arch-AT-vger.kernel.org>, David Rientjes <rientjes-AT-google.com>, Mathias Krause <minipli-AT-googlemail.com>, "kernel-hardening-AT-lists.openwall.com" <kernel-hardening-AT-lists.openwall.com>, "David S. Miller" <davem-AT-davemloft.net>, Laura Abbott <labbott-AT-fedoraproject.or |
| Archive‑link: | |
Article |
On Jul 6, 2016 6:25 PM, "Kees Cook" <keescook@chromium.org> wrote:
>
> Hi,
>
> This is a start of the mainline port of PAX_USERCOPY[1]. After I started
> writing tests (now in lkdtm in -next) for Casey's earlier port[2], I
> kept tweaking things further and further until I ended up with a whole
> new patch series. To that end, I took Rik's feedback and made a number
> of other changes and clean-ups as well.
>
I like the series, but I have one minor nit to pick. The effect of
this series is to harden usercopy, but most of the code is really
about infrastructure to validate that a pointed-to object is valid.
Might it make sense to call the infrastructure part something else?
After all, this could be extended in the future for memcpy or even for
some GCC plugin to check pointers passed to ordinary (non-allocator)
functions.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
