|
|
Subscribe / Log in / New account

Conflict over a code

Conflict over a code

Posted Mar 19, 2015 17:39 UTC (Thu) by viro (subscriber, #7872)
In reply to: Conflict over a code by dunlapg
Parent article: Conflict over a code

Umm... What patches would those be and when had that been? You are George Dunlap, right? Then the only commit of yours I'd been able to locate (since 2.4.0) is "perf/x86: Check all MSRs before passing hw check" two years ago. Who were the maintainers you worked with? Ingo? I had quite a few run-ins with him over the years, but it doesn't sound like him at all...

<googles a bit> The message(s) approving the patch to be accepted were "Looks good to me - Peter, any objections?" from mingo and "Nope, looks good" from peterz... Where's the emotional poison?

Or am I completely misidentifying you (or patch in question)?

Details, please. I assume that your "paint broad strokes" (rather than being exactly accurate) referred to percentages of developers with different reactions to l-k and not to the actual events you were mentioning right after that...


to post comments

Conflict over a code

Posted Mar 19, 2015 19:48 UTC (Thu) by dunlapg (guest, #57764) [Link] (7 responses)

Is this Al Viro I'm talking to then?

Yes, this is George Dunlap. Unfortunately I thought my nick was "gwd" and so would be a bit more anonymous. "dunlapg" doesn't even look like it's pretending to be. :-)

You may have noticed that I was purposely vague about the who and the what. I don't want to get into a public accusation about particular people, for a number of reasons. If you want an analysis of what was said and why I had the reaction I did because you genuinely want to understand what I'm talking about, then I'll try to write one up and mail you privately. If you just want to prove to yourself that everything's OK, I won't bother.

In any case, as the video above says, it's not about individual interactions, but about a pattern. After all, maybe the handful of interactions I had were on bad days -- for them (they were uncharacteristically harsh) or for me (I was having a bad day and misinterpreted what was said). But if a significant number of people have a significant number of negative interactions, then that's evidence of a real problem.

The tone of the LKML is infamous; it's brought up on a regular basis in public forums (e.g., https://www.youtube.com/watch?v=1Mg5_gxNXTo around 14:40 and 27:50), and mentioned in private even more. If you don't hear complaints about it, I'm not really sure what to tell you.

Conflict over a code

Posted Mar 19, 2015 20:23 UTC (Thu) by corbet (editor, #1) [Link] (6 responses)

The tone of the LKML is infamous, but I suspect it's most infamous among those who don't actually hang out there. I probably read more of LKML than just about anybody, and I often wonder where this comes from; it seems like a very 1990's view of the community. If the tone is so bad there should be plenty of examples, from within the last month, say, of unpleasant behavior. Care to point some out to me? What am I missing?

Conflict over a code

Posted Mar 19, 2015 20:54 UTC (Thu) by cesarb (subscriber, #6266) [Link]

There's probably a filter effect; people who don't have the time or inclination to follow the one-thousand-messages-per-week LKML end up reading only about the outliers. They don't read about highly technical almost-ten-levels-deep threads discussing the finer points of compiler barriers.

Conflict over a code

Posted Mar 19, 2015 21:29 UTC (Thu) by bronson (subscriber, #4806) [Link] (4 responses)

> I suspect it's most infamous among those who don't actually hang out there.

So true. Hacker News mounts up every few years to whine and moan about how poisonous the LKML is and why doesn't someone else do something about it, and then goes away.

Here's a somewhat recent example: https://news.ycombinator.com/item?id=8415667

Without exception (that I can find), those screaming the loudest are also those who have never subscribed.

To flip out about someone's public behavior, especially when your entire knowledge is based on cherry-picked tabloid quotes and not any first-hand experience... That feels somewhat hypocritical TBH.

Conflict over a code

Posted Mar 19, 2015 21:32 UTC (Thu) by bronson (subscriber, #4806) [Link] (1 responses)

I should have made it clear: yes, I believe the LKML has a lot of improving to do, starting with Linus himself.

But, taken as a whole, it's a pretty decent place to work. It's nowhere near as bad as the loudest commenters claim it is.

Conflict over a code

Posted Mar 19, 2015 22:31 UTC (Thu) by viro (subscriber, #7872) [Link]

Er... You do realize that Linus is not on l-k? As in, had not been subscribed to it for years and if you want him to see some mail, you'd better Cc or forward to him.

The same goes for a lot of active developers; personally, I still hadn't unsubscribed, but I end up deleting unread considerably more than 90%.

These days l-k is more of a public archival mechanism; way back then it used to function as a primary development list, but that role had already been on decline back when I first subscribed to it ('98 or so). A lot of development threads get Cc'ed there, as a courtesy and for archival purposes, but that's it. More specialized lists are different (fsdevel, linux-arch, netdev, etc.), but l-k proper is too high-volume for that.

So complaints about "LKML toxic culture" sound somewhat quaint, to be honest...

BTW, speaking of the thread where the patch from dunlapg had been discussed and accepted - he had some reasons for being annoyed in that thread, but not by emotional abuse (check yourself, it's on https://groups.google.com/forum/#!topic/linux.kernel/XIEi...; everyone had been nice and polite by any possible standards). But having the patches sit uncommented for 4 weeks total *is* annoying. The bottleneck is neither on the producing side (there's a lot of contributors and they send a lot of stuff) nor in merge bandwidth (bk had helped and git had pretty much resolved that one); it's in the bandwidth of _reviewers_. Had been that way for more than a decade now.

And getting more contributions would do nothing to alleviate that bottleneck, obviously. FWIW, last year I had been on the receiving end of rather indignant comments about the inferior workflow of the kernel developers. With python, of all things, being offered as an example of How To Do It(tm). Question that had really changed the tone of the discussion was simple - "how will your superior workflow scale to <that many> commits per month and <that many> contributors?" Both being a _lot_ more than in python git repository...

It's not that we don't need the contributions or would rather have fewer folks contributing, but that's _not_ where the worst shortage is. If the submission rate would double, we would almost certainly hit a serious crisis - most of us often have long queues of things to review and integrate as it is and doubling the inflow would flat-out exceed the available bandwidth in a lot of places.

What we need is more reviewers familiar with the kernel and it takes a while to become such ;-/ I really wish more newbies would pick an area and start RTFS looking for bugs and learning the things in there - would be a lot more useful than ten thousand first patch tweaking the amount of whitespace, both for them and for us. Oh, well...

Conflict over a code

Posted Mar 21, 2015 4:46 UTC (Sat) by marcH (subscriber, #57642) [Link] (1 responses)

> Hacker News mounts up every few years to whine and moan about how poisonous the LKML is and why doesn't someone else do something about it, and then goes away.

Unfortunately just the main way for "Journalism" to make enough money to survive. Nothing specific to hi-tech.

Conflict over a code

Posted Mar 21, 2015 6:13 UTC (Sat) by alison (subscriber, #63752) [Link]

The claim that the reputation of Linux kernel mailing lists is much, much worse than the reality is true, based on my personal experience. The problem is that the reputation may scare potential contributors away even when it is undeserved. Rather than wring our hands over bad tabloid coverage (LWN excepted!), the question is what to do about it. While the CoC seems about right for the actual situation within the kernel, it won't help us win the publicity war.

I do think that there are particular maintainers who tend to be abusive. If one were to criticize Linus' leadership, it might be to wish that he should rein in those individuals. (Don't go scrutinizing my patches, as maintainers have been unfailingly polite and encouraging to me.)


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds