|
|
Subscribe / Log in / New account

A look at the 3.12 development cycle

A look at the 3.12 development cycle

Posted Oct 23, 2013 20:32 UTC (Wed) by dougg (guest, #1894)
Parent article: A look at the 3.12 development cycle

This stuff is just for code accountants. According to git blame on sg.c the LWN editor was responsible for a single right brace in 2008?? [I guess some else changed the rest of his patch.]

Why not look for the best bug fix and reward the really hard work.


to post comments

A look at the 3.12 development cycle

Posted Oct 23, 2013 20:53 UTC (Wed) by HelloWorld (guest, #56129) [Link] (2 responses)

I can't help but agree. Well-written code tends to be much shorter than badly-written one, so the LoC numbers mean nothing. And what's even worse is that they might lead people (e. g. hiring managers) to the wrong conclusions about who is productive and who isn't. I think they're therefore worse than useless. Sorry Jon :-(

Still useful

Posted Oct 23, 2013 21:04 UTC (Wed) by david.a.wheeler (subscriber, #72896) [Link]

I suspect that a lot of code written to take "as many lines as possible" would be rejected, especially since there's an established format. So while lines of code are only a rough estimate of effort, lines of code are still strongly correlated with effort.

You could try using a SLOC-counting tool that strips out comments and blank lines.

A look at the 3.12 development cycle

Posted Oct 23, 2013 21:45 UTC (Wed) by dashesy (guest, #74652) [Link]

If hiring management looks at LoC to hire, it is them to blame for demise of their company. IMO, just contributing to the kernel is enough for most positions, but more LoC also means revealing more about the talent, just more material to look in the eyes of the wise :)

A look at the 3.12 development cycle

Posted Oct 24, 2013 8:58 UTC (Thu) by corbet (editor, #1) [Link] (1 responses)

Trust me, I know that these are poor metrics. I sure wish I could come up with a better one that would scale to a project with tens of thousands of commits every year...

A look at the 3.12 development cycle

Posted Oct 29, 2013 21:50 UTC (Tue) by eternaleye (guest, #67051) [Link]

Well, one thing that would interest me is checking _negative_ metrics - how many patches were reverted? What's the distribution of CVEs among git blame? The main problem I see there is that while these are 'negative' metrics in the sense of 'there was a problem' they'd likely get interpreted in the sense of 'this person is a problem'.

The _benefit_ is that they might indicate places where more documentation, more review, or other such things are needed. If, for instance, (random subsystem, not actually based on anything) networking code sees a higher rate of reversions or CVEs per commit or changed line, that could be a damn good signal that there needs to be some examination of why it happens. It could be that networking code is just plain more exposed as an attack surface, but it could also be something resolvable.

From another angle, debiting reversions against the reverted patch author's commits and lines of code could be interesting as a reverted commit is a no-op in terms of useful change, even though (as Linus has had to point out at times) it's certainly not a no-op in terms of code.

Another interesting thought is the number of first-time contributors per kernel, or new email domains (likely correlated to new companies becoming involved in development) - those would be well worth bringing up, and acknowledging them could have beneficial effects by rewarding participation (and providing a signal to people like me of companies that might be worth looking into/supporting/checking out the products of).

A look at the 3.12 development cycle

Posted Oct 24, 2013 21:27 UTC (Thu) by jani (subscriber, #74547) [Link]

> Why not look for the best bug fix and reward the really hard work.

In this respect, it would be interesting to see similar statistics for commits backported to stable kernels.


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds