|
|
Subscribe / Log in / New account

flink() at last?

flink() at last?

Posted Aug 13, 2013 13:14 UTC (Tue) by spender (guest, #23067)
In reply to: flink() at last? by alonz
Parent article: flink() at last?

It's interesting that you twisted the quote in such a way as to create the straw man you want to demonize.

The main point was the complete absence of any mention of security impact in the commit message (what the "censorship" of disclosure) was referring to. Choosing not to attribute it as well was just the icing on the spite cake.

Here are the facts:
I reported this directly to Petr on IRC
I had already fixed the vulnerability myself in the one affected grsecurity patch the night before, with an unmistakable commit message
Security impact was known at the time the patch was created
A CVE had already been allocated prior to the patch being created

No CVE or impact at all was mentioned in the commit
It seems that despite a bug being a bug (according to Linus) the advice from Andrew Morton (https://lkml.org/lkml/2012/6/13/502) continues to be ignored quite often specifically for security vulnerabilities
https://git.kernel.org/cgit/linux/kernel/git/stable/linux...
Everyone whose name appears on that commit is complicit in the behavior, no matter what they say about how they really feel about the upstream security disclosure policies on private mailing lists or in private mail because they don't want to upset Linus' silent-fix campaign.

Since when does my sphere of responsibility extend beyond my own users? Any direct reporting we've done is not under any kind of obligation (of the kind upstream has to the code they distribute), and you should understand it in that context. We find and fix tons of problems in the upstream kernels, including finding many security fixes that fall through the backporting cracks (due in large part to the active cover-up policy) -- this is but one minor example because I chose to directly report it due to the apparent complete absence of QA regarding the use of unprivileged user namespaces. As I mentioned in my commit message, it's a trivial, 22 character local DoS (which I think may be the smallest ever reported).

Now, try hard to think about this as a smart person would: if some group were consistently finding vulnerabilities in my software, would it not be wise to monitor that code to spot those things, given that they're not being obfuscated at all? Apparently in 13 years, the Linux kernel devs still have not figured this one out. "That's work they shouldn't have to do!" a hypocrite might say. Yes, just as I shouldn't have to be scouring upstream commits (across all developers, not just us two, so there's quite some asymmetry of effort here) to find the silent security fixes falling through the cracks.

I believe in the old adage that actions speak louder than words. I've "joined the dark side" because I refuse to support and enable a system actively engaged in pulling the wool over your eyes as to the security of their code? Apparently as the arbitrator of ethics and morality, do you suggest I continue to piss away one-off vulnerabilities so they can be fixed in a one-off fashion with the associated coverup? Do you not see the long-term ramifications of that in pursuit of some short-term benefit?

-Brad


to post comments

flink() at last?

Posted Aug 13, 2013 15:07 UTC (Tue) by idle (guest, #5017) [Link] (2 responses)

> The main point was the complete absence of any mention of
> security impact in the commit message

Well, the changelog explains that we leak the memory. Doesn't
this obviously mean the bad impact?

I do not think that the fact it was reported via oss-sec list
does matter, the bug is bug. In fact I didn't even notice this
list in CC.

But. I am really sorry I didn't add Reported-by tag, seriously.
This is only because I didn't know whom should we thank. I sent
the patch for review and I specially asked about the reporter,
but the patch was merged immediately and I could not update the
changelog.

flink() at last?

Posted Aug 13, 2013 15:41 UTC (Tue) by spender (guest, #23067) [Link] (1 responses)

Does it? There are no matches for either "leak" or "memory" in the commit message.

There is only vague mention of unspecified "side effects" that need "taking care of" in response to a function failure. Failures can be of the unfailable kmalloc+GFP_KERNEL kind, after all. I wonder how anyone, not already knowing about the CVE and public disclosure from elsewhere, would have any clue what the impact of that fix is.

Are you really trying to say the commit message was written with clarity and transparency of the impact of the fix in mind, without some Linus-enforced brain filter on what words you're allowed to use to describe the "bug"?

-Brad

flink() at last?

Posted Aug 13, 2013 16:07 UTC (Tue) by idle (guest, #5017) [Link]

> Does it? There are no matches for either "leak" or "memory"
> in the commit message.

I thought that "take care of" should be clear enough, and it
mentions put_cred().

> There is only vague mention of unspecified "side effects"

This just tries to explain why the patch didn't change the
caller instead, the patch would be even simpler.

> Are you really trying to say the commit message was written
> with clarity and transparency of the impact of the fix in mind

OK. When I reread it I agree, it could be more clear. Trust me,
this was not intentional. I did not try to "hide" the fact this
patch fixes the easily triggable memory leak.

It would be just silly, exactly because it was not me who founf
the bug!

> Linus-enforced brain filter on what words you're allowed to
> use to describe the "bug"?

What are you talking about ;) Nobody will ever try to force you
obfuscate the changelog.


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds