|
|
Subscribe / Log in / New account

What's missing from our changelogs

What's missing from our changelogs

Posted Jul 24, 2013 22:43 UTC (Wed) by blackwood (guest, #44174)
In reply to: What's missing from our changelogs by lrothc
Parent article: What's missing from our changelogs

In drm/i915 I simply demand that review needs to be reflected in the commit, no matter what. So either the patch gets updated or the commit message needs improvement since if it would have been perfect no questions would have popped up in review.

For similar reasons I also insist that the revision log of individual patches is kept as part of the commit message (and not hidden below the -- line). We also use a bit more elaborate commit message citation layout (essentially git show up to the patch headline) so that author, committer, sha1 and headline is all there at a glance.

It's a lot more work than onleliners but imo enforcing high standars for commit messages is really worth it when digging through history.


to post comments


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds