Re: [PATCH 01/17] cgroup: remove incorrect dget/dput() pair in
cgroup_create_dir()
[Posted November 21, 2012 by corbet]
| From: |
| Tejun Heo <tj-AT-kernel.org> |
| To: |
| Li Zefan <lizefan-AT-huawei.com> |
| Subject: |
| Re: [PATCH 01/17] cgroup: remove incorrect dget/dput() pair in
cgroup_create_dir() |
| Date: |
| Mon, 19 Nov 2012 08:28:55 -0800 |
| Message-ID: |
| <20121119162855.GD15971@htj.dyndns.org> |
| Cc: |
| containers-AT-lists.linux-foundation.org, cgroups-AT-vger.kernel.org,
linux-kernel-AT-vger.kernel.org, mhocko-AT-suse.cz,
glommer-AT-parallels.com, stable-AT-vger.kernel.org |
| Archive‑link: | |
Article |
On Mon, Nov 19, 2012 at 04:08:04PM +0800, Li Zefan wrote:
> > diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> > index 0f8fa6a..d0803f0 100644
> > --- a/kernel/cgroup.c
> > +++ b/kernel/cgroup.c
> > @@ -2684,9 +2684,7 @@ static int cgroup_create_dir(struct cgroup *cgrp, struct dentry *dentry,
> > dentry->d_fsdata = cgrp;
> > inc_nlink(parent->d_inode);
> > rcu_assign_pointer(cgrp->dentry, dentry);
> > - dget(dentry);
> > }
> > - dput(dentry);
> >
>
> The code has been there since cgroup was merged into mainline!
I know. Sometimes it's scary how many latent bugs we have in the
kernel and how long many of them have been around. At other times,
it's comforting. I mean, there's a pretty good chance that other
people don't notice my screw ups, right? :P
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
