Re: [PATCH 11/39] autonuma: CPU follow memory algorithm
[Posted March 27, 2012 by corbet]
| From: |
| Peter Zijlstra <a.p.zijlstra-AT-chello.nl> |
| To: |
| Andrea Arcangeli <aarcange-AT-redhat.com> |
| Subject: |
| Re: [PATCH 11/39] autonuma: CPU follow memory algorithm |
| Date: |
| Mon, 26 Mar 2012 20:25:53 +0200 |
| Message-ID: |
| <1332786353.16159.173.camel@twins> |
| Cc: |
| linux-kernel-AT-vger.kernel.org, linux-mm-AT-kvack.org, Hillf Danton
<dhillf-AT-gmail.com>, Dan Smith <danms-AT-us.ibm.com>, Linus Torvalds
<torvalds-AT-linux-foundation.org>, Andrew Morton <akpm-AT-linux-foundation.org>,
Thomas Gleixner <tglx-AT-linutronix.de>, Ingo Molnar <mingo-AT-elte.hu>, Paul
Turner <pjt-AT-google.com>, Suresh Siddha <suresh.b.siddha-AT-intel.com>, Mike
Galbraith <efault-AT-gmx.de>, "Paul E. McKenney" <paulmck-AT-linux.vnet.ibm.com>,
Lai Jiangshan <laijs-AT-cn.fujitsu.com>, Bharata B Rao
<bharata.rao-AT-gmail.com>, Lee Schermerhorn <Lee.Schermerhorn-AT-hp.com>, Rik
van Riel <riel-AT-redhat.com>, Johannes Weiner <hannes-AT-cmpxchg.org> |
| Archive‑link: | |
Article |
On Mon, 2012-03-26 at 19:45 +0200, Andrea Arcangeli wrote:
> @@ -3220,6 +3214,8 @@ need_resched:
>
> post_schedule(rq);
>
> + sched_autonuma_balance();
> +
> sched_preempt_enable_no_resched();
> if (need_resched())
> goto need_resched;
I already told you, this isn't ever going to happen. You do _NOT_ put a
for_each_online_cpu() loop in the middle of schedule().
You also do not call stop_one_cpu(migration_cpu_stop) in schedule to
force migrate the task you just scheduled to away from this cpu. That's
retarded.
Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
