Re: [PATCH v4] futex: Fix regression with read only mappings
[Posted July 7, 2011 by corbet]
| From: |
| Thomas Gleixner <tglx-AT-linutronix.de> |
| To: |
| Shawn Bohrer <sbohrer-AT-rgmadvisors.com> |
| Subject: |
| Re: [PATCH v4] futex: Fix regression with read only mappings |
| Date: |
| Thu, 30 Jun 2011 01:38:41 +0200 (CEST) |
| Message-ID: |
| <alpine.LFD.2.02.1106300129130.2917@ionos> |
| Cc: |
| Darren Hart <dvhart-AT-linux.intel.com>,
KOSAKI Motohiro <kosaki.motohiro-AT-jp.fujitsu.com>,
peterz-AT-infradead.org, eric.dumazet-AT-gmail.com,
david-AT-rgmadvisors.com, linux-kernel-AT-vger.kernel.org,
zvonler-AT-rgmadvisors.com, hughd-AT-google.com, mingo-AT-elte.hu |
| Archive‑link: | |
Article |
On Wed, 29 Jun 2011, Shawn Bohrer wrote:
>
> While fixing the regression this patch opens up a possible bad
> scenarios as identified by KOSAKI Motohiro:
>
> This patch also allows FUTEX_WAIT on RO private mappings which have
> the following corner case.
These two sentences make no sense at all. We really need a very
accurate description of this change. That code is subtle and we really
want to have a very clear and understandable changelog.
Your changelog fails the basic test by mentioning "corner case" simply
because the whole futex code consists only of corner cases.
Thanks,
tglx
