Re: [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver
registration.
[Posted March 23, 2011 by corbet]
| From: |
| Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io-AT-public.gmane.org> |
| To: |
| Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ-AT-public.gmane.org> |
| Subject: |
| Re: [RFC PATCH 1/2] serial: 8250: Add a notifier chain for driver
registration. |
| Date: |
| Thu, 17 Mar 2011 19:24:41 +0000 |
| Message-ID: |
| <20110317192441.69c699b1@lxorguk.ukuu.org.uk> |
| Cc: |
| devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ-AT-public.gmane.org, gregkh-l3A5Bk7waGM-AT-public.gmane.org,
David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8-AT-public.gmane.org>,
linux-serial-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org |
| Archive‑link: | |
Article |
> > If we did that, serial8250_probe() would automatically do the right thing.
>
> Take a look at the way arch/powerpc/platforms/512x/pdm360ng.c uses a
> notifier for amending a platform_device with additional data..
I tend to view arch specific embedded code as rather like very dubious
parties. What goes on in other peoples' house out of sight is none of my
business.
The 8250 however is core code so it should keep its clothers on and behave
in a manner befitting its status.
What part of the problem can't be solved by doing it properly using the
device registration interfaces we have today ?
Alan
