|
|
Subscribe / Log in / New account

kernel/time: Make /proc/timer_list mode 0400

From:  Marcus Meissner <meissner@suse.de>
To:  tglx@linutronix.de, mingo@elte.hu, a.p.zijlstra@chello.nl, akpm@linux-foundation.org, rusty@rustcorp.com.au, torvalds@linux-foundation.org
Subject:  [PATCH] kernel/time: Make /proc/timer_list mode 0400
Date:  Wed, 17 Nov 2010 18:08:22 +0100
Message-ID:  <20101117170822.GW20727@suse.de>
Cc:  linux-kernel@vger.kernel.org
Archive‑link:  Article

Hi,

/proc/timer_list contains kernel addresses, like e.g.:
 #0: <c000000001404158>, tick_sched_timer, S:01, .tick_nohz_restart_sched_tick, swapper/0
 ...

Avoid leaking them to user space to make writing kernel exploits a bit harder.

(I currently cannot think of a userland tool that uses this, this is
likely pretty much root-only.)

Ciao, Marcus

Signed-off-by: Marcus Meissner <meissner@suse.de>
---
 kernel/time/timer_list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
index ab8f5e3..5ae1ce3 100644
--- a/kernel/time/timer_list.c
+++ b/kernel/time/timer_list.c
@@ -293,7 +293,7 @@ static int __init init_timer_list_procfs(void)
 {
 	struct proc_dir_entry *pe;
 
-	pe = proc_create("timer_list", 0444, NULL, &timer_list_fops);
+	pe = proc_create("timer_list", 0400, NULL, &timer_list_fops);
 	if (!pe)
 		return -ENOMEM;
 	return 0;
-- 
1.7.1



Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds