Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr
problem
[Posted August 18, 2010 by jake]
| From: |
| Linus Torvalds <torvalds-AT-linux-foundation.org> |
| To: |
| Herbert Xu <herbert-AT-gondor.hengli.com.au> |
| Subject: |
| Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr
problem |
| Date: |
| Thu, 5 Aug 2010 19:01:21 -0700 |
| Message-ID: |
| <AANLkTi=+-Y2GOZYAZHeaX+op3XB9AY5S85rfJD3jSDvz@mail.gmail.com> |
| Cc: |
| David Howells <dhowells-AT-redhat.com>, gregkh-AT-suse.de,
linux-kernel-AT-vger.kernel.org, linux-crypto-AT-vger.kernel.org |
| Archive‑link: | |
Article |
On Thu, Aug 5, 2010 at 6:40 PM, Herbert Xu <herbert@gondor.hengli.com.au> wrote:
>
> -config CRYPTO_MANAGER_TESTS
> - bool "Run algolithms' self-tests"
> - default y
> - depends on CRYPTO_MANAGER2
> +config CRYPTO_MANAGER_DISABLE_TESTS
> + bool "Disable run-time self tests"
> + depends on CRYPTO_MANAGER2 && EMBEDDED
Why do you still want to force-enable those tests? I was going to
complain about the "default y" anyway, now I'm _really_ complaining,
because you've now made it impossible to disable those tests. Why?
People always think that their magical code is so important. I tell
you up-front that is absolutely is not. Just remove the crap entirely,
please.
Linus
