|
|
Subscribe / Log in / New account

Kees Cook: yay for barriers

Kees Cook: yay for barriers

Posted May 18, 2010 14:19 UTC (Tue) by blitzkrieg3 (guest, #57873)
Parent article: Kees Cook: yay for barriers

Disclaimer, I'm a Red Hat employee.

I have mixed feelings on the issue. Kees didn't really do anything wrong. Ted said that Fedora doesn't have the problem, so I think anyone's natural reaction would be to test Fedora and then, if it didn't have the problem, bisect the patches. Then he linked the upstream bug so Fedora guys essentially had no overhead in finding the fix and closing the bug.

However, the fact remains that Eric Sandeen, a Red Hat employee, did a good deal of root cause analysis on the bug. Was this bug more deserving of his attention than the 1628 other bugs for fedora+kernel that are presumably impacting fedora users? Or the bugs filed against RHEL+kernel that paying customers want fixed?

The short answer is that he would have gotten involved anyway since he's an upstream dev, and the bug was also filed against upstream. And Kees may have done a lot to help out Red Hat here, after all he did a lot of analysis and found a reproducer, which is a mundane and time consuming job. Maybe the per-bdi thread flush patch is in RHEL 6, and Red Hat wouldn't have caught it until after a customer hit it. Then Red Hat has to do all of Kees work anyhow, and the customer leaves with a bad taste in their mouth. Or maybe no one would have hit it in any Red Hat distro. Who knows?

The point is that Kees did the right thing, and Fedora has a right to be miffed. Not that they are, mind you. As others have pointed out, almost none of the criticism has come from Fedora devs.


to post comments

Kees Cook: yay for barriers

Posted May 18, 2010 16:43 UTC (Tue) by jspaleta (subscriber, #50639) [Link]

I mostly agree. Ted's comment does imply that this should be tested on Fedora. If I had an upstream developer tell me that a bug I was seeing in one of the packages I maintain in Fedora was not occurring in Ubuntu I'd eventually have to do a comparison and find a common reproducer if I couldn't track it down internally with the help of other Fedora developers.

If I went to all the trouble I'd certainly let the Ubuntu maintainers know, but maybe back channel and only file it after it was clear that an active ubuntu user was going to take responsibility for the report if more information is needed. I've shared crash fix patches with Ubuntu maintainers in the past for an application project with an effectively dead upstream. Though I'm not sure if making a habit of cross-distro bug reports that don't include patches would be considered.. neighbourly. Even more so if I'm just driving by and not planning on continuing to run the distro so I can provide additional feedback as the reporter.

-jef


Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds