Re: [GIT PATCH] USB patches for 2.6-git

[Posted October 21, 2008 by corbet]

From:		Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b-AT-public.gmane.org>
To:		Greg KH <gregkh-l3A5Bk7waGM-AT-public.gmane.org>
Subject:		Re: [GIT PATCH] USB patches for 2.6-git
Date:		Fri, 17 Oct 2008 15:47:58 -0700 (PDT)
Message-ID:		<alpine.LFD.2.00.0810171544320.3438@nehalem.linux-foundation.org>
Cc:		Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b-AT-public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org
Archive‑link:		Article

On Fri, 17 Oct 2008, Greg KH wrote:
>
> Here is the big batch of USB patches for your 2.6-git tree.

I really wish I were to get the occasional _clean_ pull for a change.

f*ck me, but why do people keep adding more and more warnings, and 
apparently not even bother to write clean code? The merge window is no 
excuse for badly written crap.

  drivers/usb/host/ehci-hcd.c: In function ?ehci_hcd_init?:
  drivers/usb/host/ehci-hcd.c:1115: warning: label ?err_debug? defined but not used

That particular function is just about the ugliest thing I've ever seen, 
and now it's adding annoying warnings too!

Yeah, I'm grumpy. The quality control during this merge window has been 
absolutely disgusting. I feel like I have to complain about every other 
pull I do, because people feel like another new warning isn't a problem. 
And every single time, the new warning is due to some total crap code.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html