Re: [PATCH] fs: Restore files_lock and set_fs_root exports

[Posted January 12, 2005 by corbet]

From:		Linus Torvalds <torvalds-AT-osdl.org>
To:		Alan Cox <alan-AT-lxorguk.ukuu.org.uk>
Subject:		Re: [PATCH] fs: Restore files_lock and set_fs_root exports
Date:		Thu, 6 Jan 2005 16:24:58 -0800 (PST)
Cc:		Andrew Morton <akpm-AT-osdl.org>, Al Viro <viro-AT-parcelfarce.linux.theplanet.co.uk>, paulmck-AT-us.ibm.com, arjan-AT-infradead.org, Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>, jtk-AT-us.ibm.com, wtaber-AT-us.ibm.com, pbadari-AT-us.ibm.com, markv-AT-us.ibm.com, greghk-AT-us.ibm.com

On Thu, 6 Jan 2005, Alan Cox wrote:

> On Iau, 2005-01-06 at 23:26, Andrew Morton wrote:
> > I think the exports should be restored.  So does Linus ("Not that I like
it
> > all that much, but I don't think we should break existing modules unless
we
> > have a very specific reason to break just those modules.").
> 
> What happens when the feature is just not (ab)usable in the way proposed ? 

At that point there is a specific _reason_ to break it, aka "that function 
simply doesn't exist any more".

I'm known for happily breaking binary modules, but I think we should do it 
only if we have a reason _other_ than "let's break a module". 

		Linus