| From: |
| Zhi Wang <zhiw-AT-nvidia.com> |
| To: |
| <rust-for-linux-AT-vger.kernel.org> |
| Subject: |
| [PATCH v3 0/5] rust: pci: add config space read/write support |
| Date: |
| Thu, 30 Oct 2025 15:48:37 +0000 |
| Message-ID: |
| <20251030154842.450518-1-zhiw@nvidia.com> |
| Cc: |
| <dakr-AT-kernel.org>, <bhelgaas-AT-google.com>, <kwilczynski-AT-kernel.org>, <ojeda-AT-kernel.org>, <alex.gaynor-AT-gmail.com>, <boqun.feng-AT-gmail.com>, <gary-AT-garyguo.net>, <bjorn3_gh-AT-protonmail.com>, <lossin-AT-kernel.org>, <a.hindborg-AT-kernel.org>, <aliceryhl-AT-google.com>, <tmgross-AT-umich.edu>, <linux-pci-AT-vger.kernel.org>, <linux-kernel-AT-vger.kernel.org>, <cjia-AT-nvidia.com>, <smitra-AT-nvidia.com>, <ankita-AT-nvidia.com>, <aniketa-AT-nvidia.com>, <kwankhede-AT-nvidia.com>, <targupta-AT-nvidia.com>, <zhiw-AT-nvidia.com>, <zhiwang-AT-kernel.org>, <acourbot-AT-nvidia.com>, <joelagnelf-AT-nvidia.com>, <jhubbard-AT-nvidia.com>, <markus.probst-AT-posteo.de> |
| Archive-link: |
| Article |
In the NVIDIA vGPU RFC [1], the PCI configuration space access is
required in nova-core for preparing gspVFInfo when vGPU support is
enabled. This series is the following up of the discussion with Danilo
for how to introduce support of PCI configuration space access in Rust
PCI abstrations.
v3:
- Turn offset_valid() into a private function of kernel::io:Io. (Alex)
- Separate try and non-try variants. (Danilo)
- Move all the {try_}{read,write}{8,16,32,64} accessors to the I/O trait.
(Danilo)
- Replace the hardcoded MMIO type constraint with a generic trait bound
so that register! macro can be used in other places. (Danilo)
- Fix doctest. (John)
- Add an enum for PCI configuration space size. (Danilo)
- Refine the patch comments. (Bjorn)
This ideas of this series are:
- Factor out a common trait IoRegion for other accessors to share the
same compiling/runtime check like before.
- Factor the MMIO read/write macros from the define_read! and
define_write! macros. Thus, define_{read, write}! can be used in other
backend.
In detail:
* Introduce `call_mmio_read!` and `call_mmio_write!` helper macros
to encapsulate the unsafe FFI calls.
* Update `define_read!` and `define_write!` macros to delegate to
the call macros.
* Export `define_read` and `define_write` so they can be reused
for other I/O backends (e.g. PCI config space).
- Add a helper to query configuration space size. This is mostly for
runtime check.
- Implement the PCI configuration space access backend in PCI
Abstractions.
- Add tests for config space routines in rust PCI sample driver.
Zhi Wang (5):
rust: io: factor common I/O helpers into Io trait and specialize
Mmio<SIZE>
rust: io: factor out MMIO read/write macros
rust: pci: add a helper to query configuration space size
rust: pci: add config space read/write support
sample: rust: pci: add tests for config space routines
drivers/gpu/nova-core/regs/macros.rs | 90 +++++---
drivers/gpu/nova-core/vbios.rs | 1 +
rust/kernel/devres.rs | 12 +-
rust/kernel/io.rs | 333 +++++++++++++++++++++------
rust/kernel/io/mem.rs | 16 +-
rust/kernel/io/poll.rs | 4 +-
rust/kernel/pci.rs | 94 +++++++-
samples/rust/rust_driver_pci.rs | 28 ++-
8 files changed, 444 insertions(+), 134 deletions(-)
--
2.47.3
