Lynx 28G improvements part 1
From: | Vladimir Oltean <vladimir.oltean-AT-nxp.com> | |
To: | linux-phy-AT-lists.infradead.org | |
Subject: | [PATCH v3 phy 00/17] Lynx 28G improvements part 1 | |
Date: | Fri, 26 Sep 2025 21:04:48 +0300 | |
Message-ID: | <20250926180505.760089-1-vladimir.oltean@nxp.com> | |
Cc: | Ioana Ciornei <ioana.ciornei-AT-nxp.com>, Vinod Koul <vkoul-AT-kernel.org>, Kishon Vijay Abraham I <kishon-AT-kernel.org>, Josua Mayer <josua-AT-solid-run.com>, linux-kernel-AT-vger.kernel.org, Rob Herring <robh-AT-kernel.org>, Krzysztof Kozlowski <krzk+dt-AT-kernel.org>, Conor Dooley <conor+dt-AT-kernel.org>, devicetree-AT-vger.kernel.org | |
Archive-link: | Article |
This is the first part in upstreaming a set of around 100 patches that were developed in NXP's vendor Linux Factory kernel over the course of several years. This part is mainly concerned with correcting some historical mistakes which make extending the driver more difficult: - the register naming scheme forces us to modify a single register field per lynx_28g_lane_rmw() call - leads to inefficient code - lynx_28g_lane_set_sgmii(), lynx_28g_lane_set_10gbaser() are unfit for their required roles when the current SerDes protocol is 25GBase-R. They are replaced with a better structured approach. - USXGMII and 10GBase-R have different protocol converters, and should be treated separately by the SerDes driver. - Lane power management does not really power down the lanes. - Consumer drivers using phy_exit() would cause the kernel to hang. - The 3 instances of this SerDes block, as seen on NXP LX2160A, need to be differentiated somehow, because otherwise, the driver cannot reject a configuration which is unsupported by the hardware. The proposal is to do that based on compatible string. In addition to the above, a new feature is also added in patch 14/17: 25GBase-R. Code allowing this mode to be used is also necessary in the Ethernet MAC and PCS drivers - not present here. The set grew in size (sorry!) from v1 here: https://lore.kernel.org/lkml/20250904154402.300032-1-vlad... due to Josua's request for a device tree binding where individual lanes have their own OF nodes. This seems to be the right moment to make that change. It also grew in size from v2 due to Josua's request to avoid unbounded loops waiting for lane resets/halts/stops to complete: https://lore.kernel.org/lkml/d0c8bbf8-a0c5-469f-a148-de22... Detailed change log in individual patches. Thanks to Josua, Rob, Conor, Krzysztof, Ioana who provided feedback on the previous version, and I hope it has all been addressed. Cc: Rob Herring <robh@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: devicetree@vger.kernel.org Ioana Ciornei (2): phy: lynx-28g: configure more equalization params for 1GbE and 10GbE phy: lynx-28g: add support for 25GBASER Vladimir Oltean (15): phy: lynx-28g: remove LYNX_28G_ prefix from register names phy: lynx-28g: don't concatenate lynx_28g_lane_rmw() argument "reg" with "val" and "mask" phy: lynx-28g: use FIELD_GET() and FIELD_PREP() phy: lynx-28g: convert iowrite32() calls with magic values to macros phy: lynx-28g: restructure protocol configuration register accesses phy: lynx-28g: make lynx_28g_set_lane_mode() more systematic phy: lynx-28g: refactor lane->interface to lane->mode phy: lynx-28g: distinguish between 10GBASE-R and USXGMII phy: lynx-28g: use "dev" argument more in lynx_28g_probe() phy: lynx-28g: improve lynx_28g_probe() sequence dt-bindings: phy: lynx-28g: add compatible strings per SerDes and instantiation phy: lynx-28g: probe on per-SoC and per-instance compatible strings phy: lynx-28g: use timeouts when waiting for lane halt and reset phy: lynx-28g: truly power the lanes up or down phy: lynx-28g: implement phy_exit() operation .../devicetree/bindings/phy/fsl,lynx-28g.yaml | 159 +- drivers/phy/freescale/phy-fsl-lynx-28g.c | 1505 +++++++++++++---- 2 files changed, 1366 insertions(+), 298 deletions(-) -- 2.34.1