| From: |
| Vadim Fedorenko <vadim.fedorenko-AT-linux.dev> |
| To: |
| Jakub Kicinski <kuba-AT-kernel.org>, Andrew Lunn <andrew-AT-lunn.ch>, Michael Chan <michael.chan-AT-broadcom.com>, Pavan Chebbi <pavan.chebbi-AT-broadcom.com>, Tariq Toukan <tariqt-AT-nvidia.com>, Gal Pressman <gal-AT-nvidia.com>, intel-wired-lan-AT-lists.osuosl.org, Donald Hunter <donald.hunter-AT-gmail.com>, Carolina Jubran <cjubran-AT-nvidia.com>, Aleksandr Loktionov <aleksandr.loktionov-AT-intel.com>, Vadim Fedorenko <vadim.fedorenko-AT-linux.dev> |
| Subject: |
| [PATCH net-next v4 0/5] add FEC bins histogram report via ethtool |
| Date: |
| Fri, 19 Sep 2025 19:46:46 +0000 |
| Message-ID: |
| <20250919194651.2164987-1-vadim.fedorenko@linux.dev> |
| Cc: |
| Paolo Abeni <pabeni-AT-redhat.com>, Simon Horman <horms-AT-kernel.org>, netdev-AT-vger.kernel.org |
| Archive-link: |
| Article |
IEEE 802.3ck-2022 defines counters for FEC bins and 802.3df-2024
clarifies it a bit further. Implement reporting interface through as
addition to FEC stats available in ethtool. NetDevSim driver has simple
implementation as an example while mlx5 has much more complex solution.
The example query is the same as usual FEC statistics while the answer
is a bit more verbose:
[vmuser@archvm9 linux]$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/ethtool.yaml --do fec-get --json '{"header":{"dev-index": 10, "flags": 4}}'
{'auto': 0,
'header': {'dev-index': 10, 'dev-name': 'eni10np1'},
'modes': {'bits': {}, 'nomask': True, 'size': 121},
'stats': {'corr-bits': [],
'corrected': [123],
'hist': [{'bin-high': 0,
'bin-low': 0,
'bin-val': 445,
'bin-val-per-lane': [125, 120, 100, 100]},
{'bin-high': 3, 'bin-low': 1, 'bin-val': 12},
{'bin-high': 7,
'bin-low': 4,
'bin-val': 2,
'bin-val-per-lane': [2, 0, 0, 0]}],
'uncorr': [4]}}
v3 -> v4:
* update spec to avoid using underscores
* make core accumulate per-lane errors into bin error counter
* adjust wording in Documentation
* improve FEC type check in mlx5
* add selftest to do sanity check of reported histogram
* partially carry-over Rb tags from Aleksandr because of logical changes
v3 Link - https://lore.kernel.org/netdev/20250916191257.13343-1-vad...
v2 -> v3:
* fix yaml spec to use binary array for histogram per-lane values
* fix spelling
v1 -> v2:
* fix memset size of FEC histogram bins in mlx5
* adjust fbnic driver FEC stats callback
Links to RFC discussions:
v1 - https://lore.kernel.org/netdev/20250729102354.771859-1-va...
v2 - https://lore.kernel.org/netdev/20250731231019.1809172-1-v...
v3 - https://lore.kernel.org/netdev/20250802063024.2423022-1-v...
v4 - https://lore.kernel.org/netdev/20250807155924.2272507-1-v...
v5 - https://lore.kernel.org/netdev/20250815132729.2251597-1-v...
Carolina Jubran (3):
net/mlx5e: Don't query FEC statistics when FEC is disabled
net/mlx5e: Add logic to read RS-FEC histogram bin ranges from PPHCR
net/mlx5e: Report RS-FEC histogram statistics via ethtool
Vadim Fedorenko (2):
ethtool: add FEC bins histogram report
selftests: net-drv: stats: sanity check FEC histogram
Documentation/netlink/specs/ethtool.yaml | 26 ++++
Documentation/networking/ethtool-netlink.rst | 5 +
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +-
.../ethernet/fungible/funeth/funeth_ethtool.c | 3 +-
.../ethernet/hisilicon/hns3/hns3_ethtool.c | 3 +-
drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 +-
.../marvell/octeontx2/nic/otx2_ethtool.c | 3 +-
drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 +
.../ethernet/mellanox/mlx5/core/en_ethtool.c | 5 +-
.../net/ethernet/mellanox/mlx5/core/en_main.c | 8 ++
.../ethernet/mellanox/mlx5/core/en_stats.c | 125 +++++++++++++++++-
.../ethernet/mellanox/mlx5/core/en_stats.h | 3 +-
.../net/ethernet/meta/fbnic/fbnic_ethtool.c | 3 +-
drivers/net/ethernet/sfc/ethtool.c | 3 +-
drivers/net/ethernet/sfc/siena/ethtool.c | 3 +-
drivers/net/netdevsim/ethtool.c | 25 +++-
include/linux/ethtool.h | 25 +++-
.../uapi/linux/ethtool_netlink_generated.h | 11 ++
net/ethtool/fec.c | 75 ++++++++++-
tools/testing/selftests/drivers/net/stats.py | 35 ++++-
20 files changed, 345 insertions(+), 24 deletions(-)
--
2.47.3
