dpll: add all inputs phase offset monitor
From: | Arkadiusz Kubalewski <arkadiusz.kubalewski-AT-intel.com> | |
To: | donald.hunter-AT-gmail.com, kuba-AT-kernel.org, davem-AT-davemloft.net, edumazet-AT-google.com, pabeni-AT-redhat.com, horms-AT-kernel.org, vadim.fedorenko-AT-linux.dev, jiri-AT-resnulli.us, anthony.l.nguyen-AT-intel.com, przemyslaw.kitszel-AT-intel.com, andrew+netdev-AT-lunn.ch, aleksandr.loktionov-AT-intel.com, milena.olech-AT-intel.com, corbet-AT-lwn.net | |
Subject: | [PATCH net-next v6 0/3] dpll: add all inputs phase offset monitor | |
Date: | Thu, 12 Jun 2025 17:28:32 +0200 | |
Message-ID: | <20250612152835.1703397-1-arkadiusz.kubalewski@intel.com> | |
Cc: | netdev-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, intel-wired-lan-AT-lists.osuosl.org, linux-doc-AT-vger.kernel.org, Arkadiusz Kubalewski <arkadiusz.kubalewski-AT-intel.com> | |
Archive-link: | Article |
Add dpll device level feature: phase offset monitor. Phase offset measurement is typically performed against the current active source. However, some DPLL (Digital Phase-Locked Loop) devices may offer the capability to monitor phase offsets across all available inputs. The attribute and current feature state shall be included in the response message of the ``DPLL_CMD_DEVICE_GET`` command for supported DPLL devices. In such cases, users can also control the feature using the ``DPLL_CMD_DEVICE_SET`` command by setting the ``enum dpll_feature_state`` values for the attribute. Once enabled the phase offset measurements for the input shall be returned in the ``DPLL_A_PIN_PHASE_OFFSET`` attribute. Implement feature support in ice driver for dpll-enabled devices. Verify capability: $ ./tools/net/ynl/pyynl/cli.py \ --spec Documentation/netlink/specs/dpll.yaml \ --dump device-get [{'clock-id': 4658613174691613800, 'id': 0, 'lock-status': 'locked-ho-acq', 'mode': 'automatic', 'mode-supported': ['automatic'], 'module-name': 'ice', 'type': 'eec'}, {'clock-id': 4658613174691613800, 'id': 1, 'lock-status': 'locked-ho-acq', 'mode': 'automatic', 'mode-supported': ['automatic'], 'module-name': 'ice', 'phase-offset-monitor': 'disable', 'type': 'pps'}] Enable the feature: $ ./tools/net/ynl/pyynl/cli.py \ --spec Documentation/netlink/specs/dpll.yaml \ --do device-set --json '{"id":1, "phase-offset-monitor":"enable"}' Verify feature is enabled: $ ./tools/net/ynl/pyynl/cli.py \ --spec Documentation/netlink/specs/dpll.yaml \ --dump device-get [ [...] {'capabilities': {'all-inputs-phase-offset-monitor'}, 'clock-id': 4658613174691613800, 'id': 1, [...] 'phase-offset-monitor': 'enable', [...]] v6: - rebase. Arkadiusz Kubalewski (3): dpll: add phase-offset-monitor feature to netlink spec dpll: add phase_offset_monitor_get/set callback ops ice: add phase offset monitor for all PPS dpll inputs Documentation/driver-api/dpll.rst | 18 ++ Documentation/netlink/specs/dpll.yaml | 24 +++ drivers/dpll/dpll_netlink.c | 69 ++++++- drivers/dpll/dpll_nl.c | 5 +- .../net/ethernet/intel/ice/ice_adminq_cmd.h | 20 ++ drivers/net/ethernet/intel/ice/ice_common.c | 26 +++ drivers/net/ethernet/intel/ice/ice_common.h | 3 + drivers/net/ethernet/intel/ice/ice_dpll.c | 193 +++++++++++++++++- drivers/net/ethernet/intel/ice/ice_dpll.h | 8 + drivers/net/ethernet/intel/ice/ice_main.c | 4 + include/linux/dpll.h | 8 + include/uapi/linux/dpll.h | 12 ++ 12 files changed, 384 insertions(+), 6 deletions(-) base-commit: 5d6d67c4cb10a4b4d3ae35758d5eeed6239afdc8 -- 2.38.1