LWN: Comments on "Development statistics for 6.13"

Lines-changed algo?

andy_shev — Fri, 31 Jan 2025 13:30:45 +0000

It's still rare, and on top of that I precisely know what I have done in that release (most LoC changes came from removing old GPL boilerplate texts, no adding/removing whitespaces). I have just even checked by adding these to my script: "-C -D --ignore-all-space", still it gives 8790 (without 9006), but statistics shows 7755, I beleive there is a mystery (bug or feature?) in the LWN scripts. Full script for the reference I have used:

git log -M -C -D --author="Andy Shevchenko" --ignore-all-space --pretty="" --numstat v6.12..v6.13
awk RS="\n" {
	 	 for (i=0; i < int(NF / 3); i++) {
	 	 	 sum += $(3*i+1) + $(3*i+2)
	 	 }
	 } END { print sum }

I even went further and cut the filenames from the `git log` output to be sure we have only numbers and calculated a sum using `bc`, same result.

Self reviews

jan.kara — Wed, 29 Jan 2025 15:27:18 +0000

No, it isn't self-reviewed by the author. The review comes from the maintainer. And tested-by from yet another person. They are all from the same company but I don't think that matters much for driver code. For some larger common infrastructure, it would be a bit more questionable.

Self reviews

krzk — Wed, 29 Jan 2025 08:32:46 +0000

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/...

That's how you appear on lwn :). Self-reviewed from the author, tested-by and all this for change in version number. :)

Lines-changed algo?

taladar — Tue, 28 Jan 2025 12:12:06 +0000

Thousands of lines of white space changes are not that unusual if e.g. something is wrapped in a new if and then re-indented or some similar change was applied all over the code base.

Lines-changed algo?

andy_shev — Thu, 23 Jan 2025 20:23:22 +0000

Do you believe we produced N thousands lines of whitespaces (the difference between LWN statistics and mine)? :-)

Lines-changed algo?

andy_shev — Thu, 23 Jan 2025 20:22:00 +0000

Yes, `-M`, but even with `-M -C` still different numbers.

Lines-changed algo?

taladar — Wed, 22 Jan 2025 08:59:43 +0000

Maybe they use one of the options to ignore white space changes?

Emerson

happylemur — Tue, 21 Jan 2025 21:24:51 +0000

In case anyone else was confused like me, Emerson seems not to refer to Emerson Radio[1], erstwhile maker of radios and TVs, but rather Emerson Electric[2], which is in networking equipment (and data acquisition after buying National Instruments).

1. https://en.wikipedia.org/wiki/Emerson_Radio
2. https://en.wikipedia.org/wiki/Emerson_Electric

Lines-changed algo?

mathstuf — Tue, 21 Jan 2025 16:07:28 +0000

Do you have some level of copied/moved code detection enabled?

Lines-changed algo?

andy_shev — Tue, 21 Jan 2025 14:56:02 +0000

I'm puzzled by how the lines-changed algo works. My simple `git log --numstat ...` approach gives (slightly in some cases) bigger values:

Philipp Hortmann 76514
Jan Kara 32848
...
Dmitry Baryshkov 14785
...
Andy Shevchenko 9006
...

Holidays

pbonzini — Mon, 20 Jan 2025 21:59:09 +0000

Ah indeed you're talking about lunux-next, not about 6.13 having "the lowest [number of commits] since 5.15".

Holidays

pbonzini — Mon, 20 Jan 2025 21:57:22 +0000

Wouldn't that be visible in 6.14 rather than 6.13?

Holidays

willy — Mon, 20 Jan 2025 19:44:49 +0000

I'd suggest the timing of Xmas / Gregorian New Year had a large effect on the 10% reduction in patches in linux-next. Taking three weeks out of the middle of the development cycle was not helpful. Several of my patches ended up missing this merge window because of it.