| From: |
| Suren Baghdasaryan <surenb-AT-google.com> |
| To: |
| akpm-AT-linux-foundation.org |
| Subject: |
| [PATCH v2 1/3] seqlock: add raw_seqcount_try_begin |
| Date: |
| Thu, 21 Nov 2024 08:28:24 -0800 |
| Message-ID: |
| <20241121162826.987947-1-surenb@google.com> |
| Cc: |
| peterz-AT-infradead.org, andrii-AT-kernel.org, jannh-AT-google.com, Liam.Howlett-AT-oracle.com, lorenzo.stoakes-AT-oracle.com, vbabka-AT-suse.cz, mhocko-AT-kernel.org, shakeel.butt-AT-linux.dev, hannes-AT-cmpxchg.org, david-AT-redhat.com, willy-AT-infradead.org, brauner-AT-kernel.org, oleg-AT-redhat.com, arnd-AT-arndb.de, richard.weiyang-AT-gmail.com, zhangpeng.00-AT-bytedance.com, linmiaohe-AT-huawei.com, viro-AT-zeniv.linux.org.uk, hca-AT-linux.ibm.com, linux-mm-AT-kvack.org, linux-kernel-AT-vger.kernel.org, surenb-AT-google.com |
| Archive-link: |
| Article |
Add raw_seqcount_try_begin() to opens a read critical section of the given
seqcount_t if the counter is even. This enables eliding the critical
section entirely if the counter is odd, instead of doing the speculation
knowing it will fail.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
Applies over Linus' ToT
include/linux/seqlock.h | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 5298765d6ca4..22c2c48b4265 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -318,6 +318,28 @@ SEQCOUNT_LOCKNAME(mutex, struct mutex, true, mutex)
__seq; \
})
+/**
+ * raw_seqcount_try_begin() - begin a seqcount_t read critical section
+ * w/o lockdep and w/o counter stabilization
+ * @s: Pointer to seqcount_t or any of the seqcount_LOCKNAME_t variants
+ *
+ * Similar to raw_seqcount_begin(), except it enables eliding the critical
+ * section entirely if odd, instead of doing the speculation knowing it will
+ * fail.
+ *
+ * Useful when counter stabilization is more or less equivalent to taking
+ * the lock and there is a slowpath that does that.
+ *
+ * If true, start will be set to the (even) sequence count read.
+ *
+ * Return: true when a read critical section is started.
+ */
+#define raw_seqcount_try_begin(s, start) \
+({ \
+ start = raw_read_seqcount(s); \
+ !(start & 1); \
+})
+
/**
* raw_seqcount_begin() - begin a seqcount_t read critical section w/o
* lockdep and w/o counter stabilization
base-commit: 43fb83c17ba2d63dfb798f0be7453ed55ca3f9c2
--
2.47.0.338.g60cca15819-goog