|
|
Log in / Subscribe / Register

Add support for binding ACPI platform profile to multiple drivers

From:  Mario Limonciello <mario.limonciello-AT-amd.com>
To:  Hans de Goede <hdegoede-AT-redhat.com>, Ilpo Järvinen <ilpo.jarvinen-AT-linux.intel.com>
Subject:  [PATCH v2 00/15] Add support for binding ACPI platform profile to multiple drivers
Date:  Sun, 27 Oct 2024 21:01:16 -0500
Message-ID:  <20241028020131.8031-1-mario.limonciello@amd.com>
Cc:  "Rafael J . Wysocki" <rafael-AT-kernel.org>, Len Brown <lenb-AT-kernel.org>, Maximilian Luz <luzmaximilian-AT-gmail.com>, Lee Chun-Yi <jlee-AT-suse.com>, "Shyam Sundar S K" <Shyam-sundar.S-k-AT-amd.com>, Corentin Chary <corentin.chary-AT-gmail.com>, "Luke D . Jones" <luke-AT-ljones.dev>, Ike Panhc <ike.pan-AT-canonical.com>, Henrique de Moraes Holschuh <hmh-AT-hmh.eng.br>, "Alexis Belmonte" <alexbelm48-AT-gmail.com>, Uwe Kleine-König <u.kleine-koenig-AT-pengutronix.de>, Ai Chao <aichao-AT-kylinos.cn>, Gergo Koteles <soyer-AT-irl.hu>, open list <linux-kernel-AT-vger.kernel.org>, "open list:ACPI" <linux-acpi-AT-vger.kernel.org>, "open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER" <platform-driver-x86-AT-vger.kernel.org>, "open list:THINKPAD ACPI EXTRAS DRIVER" <ibm-acpi-devel-AT-lists.sourceforge.net>, Mark Pearson <mpearson-lenovo-AT-squebb.ca>, Matthew Schwartz <matthew.schwartz-AT-linux.dev>, Mario Limonciello <mario.limonciello-AT-amd.com>
Archive-link:  Article

Currently there are a number of ASUS products on the market that happen to
have ACPI objects for amd-pmf to bind to as well as an ACPI platform profile
provided by asus-wmi.

The ACPI platform profile support created by amd-pmf on these ASUS products is "Function 9"
which is specifically for "BIOS or EC notification" of power slider position.
This feature is actively used by some designs such as Framework 13 and Framework 16.

On these ASUS designs we keep on quirking more and more of them to turn off this
notification so that asus-wmi can bind.

This however isn't how Windows works.  "Multiple" things are notified for the power
slider position. This series adjusts Linux to behave similarly.

Multiple drivers can now register an ACPI platform profile and will react to set requests.

To avoid chaos, only positions that are common to both drivers are accepted.

This also allows dropping all of the PMF quirks from amd-pmf.

v2:
 * Split to many more patches
 * Account for feedback from M/L

Mario Limonciello (15):
  ACPI: platform-profile: Add a name member to handlers
  platform/surface: aggregator: Add platform handler pointer to device
  ACPI: platform_profile: Add platform handler argument to
    platform_profile_remove()
  ACPI: platform_profile: Add a list to platform profile handler
  ACPI: platform_profile: Move sanity check out of the mutex
  ACPI: platform_profile: Use guard(mutex) for register/unregister
  ACPI: platform_profile: Only remove group when no more handler
    registered
  ACPI: platform_profile: Require handlers to support balanced profile
  ACPI: platform_profile: Notify change events on register and
    unregister
  ACPI: platform_profile: Only show profiles common for all handlers
  ACPI: platform_profile: Set profile for all registered handlers
  ACPI: platform_profile: Make sure all profile handlers agree on
    profile
  ACPI: platform_profile: Check all profile handler to calculate next
  ACPI: platform_profile: Allow multiple handlers
  platform/x86/amd: pmf: Drop all quirks

 drivers/acpi/platform_profile.c               | 258 +++++++++++-------
 .../surface/surface_platform_profile.c        |   7 +-
 drivers/platform/x86/acer-wmi.c               |   5 +-
 drivers/platform/x86/amd/pmf/Makefile         |   2 +-
 drivers/platform/x86/amd/pmf/core.c           |   1 -
 drivers/platform/x86/amd/pmf/pmf-quirks.c     |  66 -----
 drivers/platform/x86/amd/pmf/pmf.h            |   3 -
 drivers/platform/x86/amd/pmf/sps.c            |   3 +-
 drivers/platform/x86/asus-wmi.c               |   5 +-
 drivers/platform/x86/dell/dell-pc.c           |   3 +-
 drivers/platform/x86/hp/hp-wmi.c              |   3 +-
 drivers/platform/x86/ideapad-laptop.c         |   3 +-
 .../platform/x86/inspur_platform_profile.c    |   5 +-
 drivers/platform/x86/thinkpad_acpi.c          |   3 +-
 include/linux/platform_profile.h              |   4 +-
 15 files changed, 190 insertions(+), 181 deletions(-)
 delete mode 100644 drivers/platform/x86/amd/pmf/pmf-quirks.c

-- 
2.43.0




Copyright © 2024, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds