|From:||Rik van Riel <riel-AT-redhat.com>|
|To:||Andrew Morton <akpm-AT-osdl.org>|
|Subject:||Re: 188.8.131.52-mm2 - reiser4|
|Date:||Fri, 20 Aug 2004 19:05:21 -0400 (EDT)|
On Fri, 20 Aug 2004, Rik van Riel wrote: > On Thu, 19 Aug 2004, Andrew Morton wrote: > > > - Added the reiser4 filesystem. Oh, and another one. The reiser 4 system call sys_reiserfs seems to need an additional patch, which is craftily hidden inside reiser4-only.patch That patch creates fs/reiser4/linux-5_reiser4_syscall.patch, which I can only assume reiser 4 users should apply... Kind of ugly. Looking further, the horrors only increase. It looks like sys_reiser4() is an interface to load programs into the kernel, with reiserfs4 containing an interpreter. I'll leave aside the issues of having a scripting language inside the kernel, since I'm sure other people will comment on it. However, I am absolutely flabbergasted that Hans Reiser is using a syscall here, instead of a filesystem interface. Furthermore, why do the parsing in the kernel, instead of compiling the human-readable strings in userspace and loading something easy to use into the kernel, like the selinux subsystem does? Since this code is bound to be horribly controversial, it may be an idea to remove this from the reiserfs4 core patch. That way the battles over the filesystem, and its interactions with the rest of the kernel can be fought first, without having the whole reiserfs4 filesystem strand in the quicksand of "why do we need an interpreted language with completely new filesystem semantics in the kernel?" -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to firstname.lastname@example.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Copyright © 2004, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds