User: Password:
|
|
Subscribe / Log in / New account

Re: [patch] enums to clear suspend-state confusion

From:  Patrick Mochel <mochel-AT-digitalimplant.org>
To:  Benjamin Herrenschmidt <benh-AT-kernel.crashing.org>
Subject:  Re: [patch] enums to clear suspend-state confusion
Date:  Wed, 18 Aug 2004 07:29:27 -0700 (PDT)
Cc:  Pavel Machek <pavel-AT-ucw.cz>, Andrew Morton <akpm-AT-osdl.org>, Linux Kernel list <linux-kernel-AT-vger.kernel.org>, David Brownell <david-b-AT-pacbell.net>


On Wed, 18 Aug 2004, Benjamin Herrenschmidt wrote:

>
> > Yes, that's exactly what I did... Unfortunately typedef means ugly
> > code. So I'll just switch it back to enum system_state, and lets care
> > about device power managment when it hits us, okay?
>
> I don't agree... with this approach, we'll have to change all drivers
> _twice_ when we move to something more descriptive than a scalar

I totally agree. Why be hasty? We need to do it right and do it once. If
that means a couple of more weeks and several more emails, than so be it.
Otherwise, we'll be stuck with a sub-par solution for who knows how long.


	Pat
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


(Log in to post comments)


Copyright © 2004, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds