| From: |
| Thomas Weißschuh <linux-AT-weissschuh.net> |
| To: |
| Pavel Machek <pavel-AT-ucw.cz>, Lee Jones <lee-AT-kernel.org>, Thomas Weißschuh <thomas-AT-weissschuh.net>, Benson Leung <bleung-AT-chromium.org>, Guenter Roeck <groeck-AT-chromium.org>, Tzung-Bi Shih <tzungbi-AT-kernel.org> |
| Subject: |
| [PATCH v2 0/5] ChromeOS Embedded Controller LED driver |
| Date: |
| Fri, 31 May 2024 18:33:30 +0200 |
| Message-ID: |
| <20240531-cros_ec-led-v2-0-6cc34408b40d@weissschuh.net> |
| Cc: |
| linux-leds-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, chrome-platform-AT-lists.linux.dev, Dustin Howett <dustin-AT-howett.net>, Mario Limonciello <mario.limonciello-AT-amd.com>, Thomas Weißschuh <linux-AT-weissschuh.net> |
| Archive-link: |
| Article |
Add a LED driver that supports the LED devices exposed by the
ChromeOS Embedded Controller.
Patch 1-3 add a utility function to the led subsystem.
Patch 4 introduces the actual driver.
Patch 5 registers the driver through the cros_ec mfd devices.
Currently the driver introduces some non-standard LED functions.
(See "cros_ec_led_functions")
Tested on a Framework 13 AMD, Firmware 3.05.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Changes in v2:
- Cosmetic cleanups (Tzung-Bi)
- Add trailing comma to MFD cell array
- Rename LEDs and trigger to "chromeos" prefix, to align with kbd
backlight driver
- Don't use type "rgb" anymore, they are only "multicolor"
- Align commit messages and subject to subsystem standards (Lee)
- Rename led_color_name() to led_get_color_name()
- The same for cros_ec_led_color_name()
- Link to v1: https://lore.kernel.org/r/20240520-cros_ec-led-v1-0-4068f...
---
Thomas Weißschuh (5):
leds: core: Introduce led_get_color_name() function
leds: multicolor: Use led_get_color_name() function
leds: core: Unexport led_colors[] array
leds: Add ChromeOS EC driver
mfd: cros_ec: Register LED subdevice
MAINTAINERS | 5 +
drivers/leds/Kconfig | 15 ++
drivers/leds/Makefile | 1 +
drivers/leds/led-class-multicolor.c | 2 +-
drivers/leds/led-core.c | 12 +-
drivers/leds/leds-cros_ec.c | 297 ++++++++++++++++++++++++++++++++++++
drivers/leds/leds.h | 1 -
drivers/mfd/cros_ec_dev.c | 9 ++
include/linux/leds.h | 10 ++
9 files changed, 348 insertions(+), 4 deletions(-)
---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240519-cros_ec-led-3efa24e3991e
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
