User: Password:
|
|
Subscribe / Log in / New account

Re: [PATCH][2.6] Completely out of line spinlocks / i386

From:  Linus Torvalds <torvalds-AT-osdl.org>
To:  Pavel Machek <pavel-AT-ucw.cz>
Subject:  Re: [PATCH][2.6] Completely out of line spinlocks / i386
Date:  Wed, 11 Aug 2004 15:13:15 -0700 (PDT)
Cc:  Zwane Mwaikambo <zwane-AT-linuxpower.ca>, Linux Kernel <linux-kernel-AT-vger.kernel.org>, Andrew Morton <akpm-AT-osdl.org>, Matt Mackall <mpm-AT-selenic.com>



On Wed, 11 Aug 2004, Pavel Machek wrote:
> 
> Fine, so perhaps we do not want config option?

The inline spinlocks are _wonderful_ for seeing where the contention is in 
a simple profile.

In contrast, in a profile the out-of-lines ones will show "x% was spent on 
spinlocks". Which doesn't help much when you want to see where the problem 
is.

This was _hugely_ useful, at least for me, for seeing what locks were 
problematic.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


(Log in to post comments)


Copyright © 2004, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds