|
|
Log in / Subscribe / Register

codingstyle: avoid unused parameters for a function-like macro

From:  Barry Song <21cnbao-AT-gmail.com>
To:  akpm-AT-linux-foundation.org, linux-doc-AT-vger.kernel.org, workflows-AT-vger.kernel.org
Subject:  [PATCH v6 0/2] codingstyle: avoid unused parameters for a function-like macro
Date:  Thu, 04 Apr 2024 11:42:52 +1300
Message-ID:  <20240403224254.10313-1-21cnbao@gmail.com>
Cc:  apw-AT-canonical.com, broonie-AT-kernel.org, chenhuacai-AT-loongson.cn, chris-AT-zankel.net, corbet-AT-lwn.net, dwaipayanray1-AT-gmail.com, herbert-AT-gondor.apana.org.au, joe-AT-perches.com, linux-kernel-AT-vger.kernel.org, linux-AT-roeck-us.net, lukas.bulwahn-AT-gmail.com, mac.xxn-AT-outlook.com, sfr-AT-canb.auug.org.au, v-songbaohua-AT-oppo.com
Archive-link:  Article

From: Barry Song <v-songbaohua@oppo.com>

-v6:
 * collect ack of Joe, thanks!
 * refine docs according to Jonathan, thanks!
 * add checkpatch doc according to Joe, thanks!

-v5:
 * Simplify the code for Patch 2 according to Joe's suggestions.
 * add s-o-b of Barry according to Jeff Johnson
 v5 link:
 https://lore.kernel.org/all/20240401012120.6052-1-21cnbao...

-v4:
 * fix Xining's email address, s/ma.xxn@outlook.com/mac.xxn@outlook.com/g
 * fix some false positives of checkpatch.pl
 * downgrade from ERROR to WARN in checkpatch.pl

 Thanks for Joe's comments!

 v4 link: https://lore.kernel.org/all/20240328022136.5789-1-21cnbao...

-v3:
 https://lore.kernel.org/all/20240322084937.66018-1-21cnba...

A function-like macro could result in build warnings such as
"unused variable." This patchset updates the guidance to
recommend always using a static inline function instead
and also provides checkpatch support for this new rule.

Barry Song (1):
  Documentation: coding-style: ask function-like macros to evaluate
    parameters

Xining Xu (1):
  scripts: checkpatch: check unused parameters for function-like macro

 Documentation/dev-tools/checkpatch.rst | 14 ++++++++++++++
 Documentation/process/coding-style.rst | 23 +++++++++++++++++++++++
 scripts/checkpatch.pl                  |  6 ++++++
 3 files changed, 43 insertions(+)

-- 
2.34.1




Copyright © 2024, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds