| From: |
| Alexei Starovoitov <alexei.starovoitov-AT-gmail.com> |
| To: |
| bpf-AT-vger.kernel.org |
| Subject: |
| [PATCH v3 bpf-next 0/4] bpf: Introduce may_goto and cond_break |
| Date: |
| Thu, 29 Feb 2024 19:37:30 -0800 |
| Message-ID: |
| <20240301033734.95939-1-alexei.starovoitov@gmail.com> |
| Cc: |
| daniel-AT-iogearbox.net, andrii-AT-kernel.org, martin.lau-AT-kernel.org, memxor-AT-gmail.com, eddyz87-AT-gmail.com, kernel-team-AT-fb.com |
| Archive-link: |
| Article |
From: Alexei Starovoitov <ast@kernel.org>
v2 -> v3: Major change
- drop bpf_can_loop() kfunc and introduce may_goto instruction instead
kfunc is a function call while may_goto doesn't consume any registers
and LLVM can produce much better code due to less register pressure.
- instead of counting from zero to BPF_MAX_LOOPS start from it instead
and break out of the loop when count reaches zero
- use may_goto instruction in cond_break macro
- recognize that 'exact' state comparison doesn't need to be truly exact.
regsafe() should ignore precision and liveness marks, but range_within
logic is safe to use while evaluating open coded iterators.
Alexei Starovoitov (4):
bpf: Introduce may_goto instruction
bpf: Recognize that two registers are safe when their ranges match
bpf: Add cond_break macro
selftests/bpf: Test may_goto
include/linux/bpf_verifier.h | 2 +
include/uapi/linux/bpf.h | 1 +
kernel/bpf/core.c | 1 +
kernel/bpf/disasm.c | 3 +
kernel/bpf/verifier.c | 269 +++++++++++++-----
tools/include/uapi/linux/bpf.h | 1 +
tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
.../testing/selftests/bpf/bpf_experimental.h | 12 +
.../bpf/progs/verifier_iterating_callbacks.c | 72 ++++-
9 files changed, 291 insertions(+), 71 deletions(-)
--
2.34.1