| From: |
| Neil Armstrong <neil.armstrong-AT-linaro.org> |
| To: |
| Andy Gross <agross-AT-kernel.org>, Bjorn Andersson <andersson-AT-kernel.org>, Konrad Dybcio <konrad.dybcio-AT-linaro.org>, Herbert Xu <herbert-AT-gondor.apana.org.au>, "David S. Miller" <davem-AT-davemloft.net>, Rob Herring <robh+dt-AT-kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt-AT-linaro.org>, Conor Dooley <conor+dt-AT-kernel.org>, Vinod Koul <vkoul-AT-kernel.org> |
| Subject: |
| [PATCH v4 0/5] arm64: qcom: sm8x50: enable RNG |
| Date: |
| Tue, 03 Oct 2023 09:10:18 +0200 |
| Message-ID: |
| <20231003-topic-sm8550-rng-v4-0-255e4d0ba08e@linaro.org> |
| Cc: |
| linux-arm-msm-AT-vger.kernel.org, linux-crypto-AT-vger.kernel.org, devicetree-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, Neil Armstrong <neil.armstrong-AT-linaro.org>, Om Prakash Singh <quic_omprsing-AT-quicinc.com>, Krzysztof Kozlowski <krzysztof.kozlowski-AT-linaro.org>, Bjorn Andersson <quic_bjorande-AT-quicinc.com> |
| Archive-link: |
| Article |
Enable RNG on SM8550 & SM8450 by reverting the PRNG bindings & DT
for SM8450 and correctly document it as a True Random Number Generator.
- SM8550 QRD test run:
smccc_trng qcom_hwrng
qcom_hwrng
rngtest 6.15
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
rngtest: starting FIPS tests...
rngtest: bits received from input: 209420032
rngtest: FIPS 140-2 successes: 10461
rngtest: FIPS 140-2 failures: 10
rngtest: FIPS 140-2(2001-10-10) Monobit: 1
rngtest: FIPS 140-2(2001-10-10) Poker: 2
rngtest: FIPS 140-2(2001-10-10) Runs: 3
rngtest: FIPS 140-2(2001-10-10) Long run: 4
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=9.219; avg=63.879; max=19073.486)Mibits/s
rngtest: FIPS tests speed: (min=24.965; avg=29.093; max=118.469)Mibits/s
rngtest: Program run time: 10002827 microseconds
- SM8450 HDK test run:
qcom_hwrng
rngtest 6.15
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
rngtest: starting FIPS tests...
rngtest: bits received from input: 420580032
rngtest: FIPS 140-2 successes: 21014
rngtest: FIPS 140-2 failures: 15
rngtest: FIPS 140-2(2001-10-10) Monobit: 2
rngtest: FIPS 140-2(2001-10-10) Poker: 0
rngtest: FIPS 140-2(2001-10-10) Runs: 7
rngtest: FIPS 140-2(2001-10-10) Long run: 6
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=15.711; avg=50.033; max=32.493)Mibits/s
rngtest: FIPS tests speed: (min=136.239; avg=203.833; max=227.065)Mibits/s
rngtest: Program run time: 10000978 microseconds
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v4:
- changed to an enum in first bindings patch to simplify sm8550 change
- integrate Om's patch from (https://lore.kernel.org/all/20230926102005.3277045-1-quic...)
to simplify maintainer's life
- rebased on next-20230929
- dropped already applied revert
- Link to v3: https://lore.kernel.org/r/20230828-topic-sm8550-rng-v3-0-...
Changes in v3:
- Removed invalid character in commit msg
- Added review tags
- Removed applied patch 1
- Link to v2: https://lore.kernel.org/r/20230824-topic-sm8550-rng-v2-0-...
Changes in v2:
- Revert SM8450 DT & bindings
- Add new qcom,trng compatible and use it for SM8450 & SM8550
- Explicitly didn't collect the Reviewed-by tags due to the compatible change
- Link to v1: https://lore.kernel.org/r/20230822-topic-sm8550-rng-v1-0-...
---
Neil Armstrong (4):
dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG
dt-bindings: crypto: qcom,prng: document SM8550
arm64: dts: qcom: sm8550: add TRNG node
arm64: dts: qcom: sm8450: add TRNG node
Om Prakash Singh (1):
crypto: qcom-rng - Add hw_random interface support
.../devicetree/bindings/crypto/qcom,prng.yaml | 26 +++++++--
arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 ++
arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 ++
drivers/crypto/qcom-rng.c | 65 +++++++++++++++++++---
4 files changed, 89 insertions(+), 12 deletions(-)
---
base-commit: df964ce9ef9fea10cf131bf6bad8658fde7956f6
change-id: 20230822-topic-sm8550-rng-c83142783e20
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
