| From: |
| André Apitzsch <git-AT-apitzsch.eu> |
| To: |
| Pavel Machek <pavel-AT-ucw.cz>, Lee Jones <lee-AT-kernel.org>, Rob Herring <robh+dt-AT-kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt-AT-linaro.org>, Conor Dooley <conor+dt-AT-kernel.org> |
| Subject: |
| [PATCH v2 0/2] leds: Add a driver for KTD202x |
| Date: |
| Fri, 01 Sep 2023 23:19:57 +0200 |
| Message-ID: |
| <20230901-ktd202x-v2-0-3cb8b0ca02ed@apitzsch.eu> |
| Cc: |
| linux-leds-AT-vger.kernel.org, devicetree-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, phone-devel-AT-vger.kernel.org, ~postmarketos/upstreaming-AT-lists.sr.ht, André Apitzsch <git-AT-apitzsch.eu> |
| Archive-link: |
| Article |
Add the binding description and the corresponding driver for
the Kinetic KTD2026 and KTD2027.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
Changes in v2:
- Make binding description filename match compatible
- Address comments by Lee Jones
- Extend driver description in Kconfig
- Add copyright + link to datasheet
- Add unit to definition/variable names, where needed
- Define magic numbers
- Remove forward declaration of 'struct ktd202x'
- Remove superfluous comments
- Get rid of struct ktd202x_info
- Join ktd202x_chip_init() with ktd202x_chip_enable()
- Return the error on ktd202x_chip_disable()
- Remove unreachable case from chip_in_use()
- Rename ktd202x_brightness_set() argument from num_colors to num_channels
- Forward errors received in ktd202x_brightness_set()
- Remove variable for 'num_channels = 1'
- Add some explanations to blink time calculation
- Remove unneeded lcdev from ktd202x_blink_*_set()
- Add define for max brightness and replace deprecated LED_FULL by it
- Move setting led_classdev.brightness to ktd202x_brightness_*_set()
- Move mutex_lock inside ktd202x_blink_set()
- Add comment that 'color' property is optional (allow EINVAL)
- Replace escaped double quotes by single quotes
- Avoid overloading variable 'color'
- Do not lock during probe
- Remove usage of 'of_match_ptr'
- Document interrupt and pull-up supply, like done for aw2013[1]
- Fix error in num_steps calculation
- Link to v1: https://lore.kernel.org/r/20230618-ktd202x-v1-0-fc182fefa...
[1] https://lore.kernel.org/linux-leds/20230815-aw2013-vio-v3...
---
André Apitzsch (2):
dt-bindings: leds: Add Kinetic KTD2026/2027 LED
leds: add ktd202x driver
.../devicetree/bindings/leds/kinetic,ktd202x.yaml | 171 ++++++
drivers/leds/rgb/Kconfig | 13 +
drivers/leds/rgb/Makefile | 1 +
drivers/leds/rgb/leds-ktd202x.c | 625 +++++++++++++++++++++
4 files changed, 810 insertions(+)
---
base-commit: a47fc304d2b678db1a5d760a7d644dac9b067752
change-id: 20230618-ktd202x-546b2a7d240b
Best regards,
--
André Apitzsch <git@apitzsch.eu>
