| From: |
| Bart Van Assche <bvanassche-AT-acm.org> |
| To: |
| Jens Axboe <axboe-AT-kernel.dk> |
| Subject: |
| [PATCH v3 0/7] Submit zoned writes in order |
| Date: |
| Mon, 22 May 2023 11:38:35 -0700 |
| Message-ID: |
| <20230522183845.354920-1-bvanassche@acm.org> |
| Cc: |
| linux-block-AT-vger.kernel.org, Christoph Hellwig <hch-AT-lst.de>, Mike Snitzer <snitzer-AT-kernel.org>, Damien Le Moal <dlemoal-AT-kernel.org>, Jaegeuk Kim <jaegeuk-AT-kernel.org>, Bart Van Assche <bvanassche-AT-acm.org> |
| Archive-link: |
| Article |
Hi Jens,
Tests with a zoned UFS prototype have shown that there are plenty of
opportunities for reordering in the block layer for zoned writes (REQ_OP_WRITE).
The UFS driver is more likely to trigger reordering than other SCSI drivers
because it reports BLK_STS_DEV_RESOURCE more often, e.g. during clock scaling.
This patch series makes sure that zoned writes are submitted in order without
affecting other workloads significantly.
Please consider this patch series for the next merge window.
Thanks,
Bart.
Changes compared to v2:
- Changed the approach from one requeue list per hctx into preserving one
requeue list per request queue.
- Rebased on top of Jens' for-next branch. Left out the mq-deadline patches
since these are already in the for-next branch.
- Modified patch "block: Requeue requests if a CPU is unplugged" such that it
always uses the requeue list.
- Added a patch that removes blk_mq_kick_requeue_list() and
blk_mq_delay_kick_requeue_list().
- Dropped patch "block: mq-deadline: Disable head insertion for zoned writes".
- Dropped patch "block: mq-deadline: Introduce a local variable".
Changes compared to v1:
- Fixed two issues detected by the kernel test robot.
Bart Van Assche (7):
block: Rename a local variable in blk_mq_requeue_work()
block: Send requeued requests to the I/O scheduler
block: Requeue requests if a CPU is unplugged
block: Make it easier to debug zoned write reordering
block: Preserve the order of requeued requests
dm: Inline __dm_mq_kick_requeue_list()
block: Inline blk_mq_{,delay_}kick_requeue_list()
block/blk-flush.c | 4 +-
block/blk-mq-debugfs.c | 2 +-
block/blk-mq.c | 107 ++++++++++++++++++-----------------
drivers/block/ublk_drv.c | 6 +-
drivers/block/xen-blkfront.c | 1 -
drivers/md/dm-rq.c | 11 +---
drivers/nvme/host/core.c | 2 +-
drivers/s390/block/scm_blk.c | 2 +-
drivers/scsi/scsi_lib.c | 2 +-
include/linux/blk-mq.h | 6 +-
include/linux/blkdev.h | 1 -
11 files changed, 69 insertions(+), 75 deletions(-)