| From: |
| Allison Henderson <allison.henderson-AT-oracle.com> |
| To: |
| linux-xfs-AT-vger.kernel.org |
| Subject: |
| [PATCH v25 00/12] Log Attribute Replay |
| Date: |
| Tue, 16 Nov 2021 21:13:31 -0700 |
| Message-ID: |
| <20211117041343.3050202-1-allison.henderson@oracle.com> |
| Archive-link: |
| Article |
Hi all,
This set is a subset of a larger series parent pointers. Delayed attributes allow
attribute operations (set and remove) to be logged and committed in the same
way that other delayed operations do. This allows more complex operations (like
parent pointers) to be broken up into multiple smaller transactions. To do
this, the existing attr operations must be modified to operate as a delayed
operation. This means that they cannot roll, commit, or finish transactions.
Instead, they return -EAGAIN to allow the calling function to handle the
transaction. In this series, we focus on only the delayed attribute portion.
We will introduce parent pointers in a later set.
The set as a whole is a bit much to digest at once, so I usually send out the
smaller sub series to reduce reviewer burn out. But the entire extended series
is visible through the included github links.
Updates since v25:
xfs: don't commit the first deferred transaction without intents
NEW
xfs: Set up infrastructure for log atrribute replay
Removed unused DAC flag XFS_DAC_DELAYED_OP_INIT
Removed uneeded header includes
Fixed ATTR_NVEC_SIZE
Modified xfs_attri_item_size and xfs_attri_item_format to avoid crash with CIL scalability patchset
Fixed malloc flags in xfs_attri_init
Changed xfs_attri_validate to take an xfs_attri_log_format
Use xfs_attri_validate in xlog_recover_attri_commit_pass2
Removed uneeded attri flag
Move *item_ops to end of file
xfs: Implement attr logging and replay
Rearrange atti/attrd functions
Added xfs_sb_is_v5 helper to xfs_sb_version_haslogxattrs
Added xfs_ prefix to sb_version_haslogxattrs
xfs: Skip flip flags for delayed attrs
Fixed fallthrough warnings
xfs: Add larp debug option
Added if def wrappers
And the test cases:
https://github.com/allisonhenderson/xfs_work/tree/pptr_xf...
In order to run the test cases, you will need have the corresponding xfsprogs
changes as well. Which can be found here:
https://github.com/allisonhenderson/xfs_work/tree/delayed...
https://github.com/allisonhenderson/xfs_work/tree/delayed...
To run the xfs attributes tests run:
check -g attr
To run as delayed attributes run:
echo 1 > /sys/fs/xfs/debug/larp;
check -g attr
To run parent pointer tests:
check -g parent
I've also made the corresponding updates to the user space side as well, and ported anything
they need to seat correctly.
Questions, comment and feedback appreciated!
Allison
Allison Collins (1):
xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred
Allison Henderson (11):
xfs: Fix double unlock in defer capture code
xfs: don't commit the first deferred transaction without intents
xfs: Return from xfs_attr_set_iter if there are no more rmtblks to
process
xfs: Set up infrastructure for log attribute replay
xfs: Implement attr logging and replay
xfs: Skip flip flags for delayed attrs
xfs: Remove unused xfs_attr_*_args
xfs: Add log attribute error tag
xfs: Add larp debug option
xfs: Merge xfs_delattr_context into xfs_attr_item
xfs: Add helper function xfs_attr_leaf_addname
fs/xfs/Makefile | 1 +
fs/xfs/libxfs/xfs_attr.c | 454 +++++++++---------
fs/xfs/libxfs/xfs_attr.h | 60 ++-
fs/xfs/libxfs/xfs_attr_leaf.c | 3 +-
fs/xfs/libxfs/xfs_attr_remote.c | 37 +-
fs/xfs/libxfs/xfs_attr_remote.h | 6 +-
fs/xfs/libxfs/xfs_defer.c | 41 +-
fs/xfs/libxfs/xfs_defer.h | 3 +
fs/xfs/libxfs/xfs_errortag.h | 4 +-
fs/xfs/libxfs/xfs_format.h | 9 +-
fs/xfs/libxfs/xfs_log_format.h | 44 +-
fs/xfs/libxfs/xfs_log_recover.h | 2 +
fs/xfs/scrub/common.c | 2 +
fs/xfs/xfs_attr_item.c | 796 ++++++++++++++++++++++++++++++++
fs/xfs/xfs_attr_item.h | 46 ++
fs/xfs/xfs_attr_list.c | 1 +
fs/xfs/xfs_error.c | 3 +
fs/xfs/xfs_globals.c | 1 +
fs/xfs/xfs_ioctl32.c | 2 +
fs/xfs/xfs_iops.c | 2 +
fs/xfs/xfs_log.c | 45 ++
fs/xfs/xfs_log.h | 12 +
fs/xfs/xfs_log_recover.c | 2 +
fs/xfs/xfs_ondisk.h | 2 +
fs/xfs/xfs_sysctl.h | 1 +
fs/xfs/xfs_sysfs.c | 24 +
fs/xfs/xfs_trace.h | 1 +
27 files changed, 1327 insertions(+), 277 deletions(-)
create mode 100644 fs/xfs/xfs_attr_item.c
create mode 100644 fs/xfs/xfs_attr_item.h
--
2.25.1